Skip to content

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Jan 19, 2024

Unfortunate that the current rtol=1e-5 hits a literal 1 / 1000000 mismatch (rtol=1.04e-5) on L40.

CC @ptrblck

cc @csarofeen @ptrblck @xwang233

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 19, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117889

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 733c4bb with merge base edd03f9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@eqy eqy added module: cublas Problem related to cublas support topic: not user facing topic category open source ciflow/trunk Trigger trunk jobs on your pull request and removed topic: not user facing topic category labels Jan 19, 2024
@cpuhrsch
Copy link
Contributor

@pytorchbot rebase

@cpuhrsch cpuhrsch requested review from cpuhrsch and malfet January 20, 2024 04:45
@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 20, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #117889, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@eqy
Copy link
Collaborator Author

eqy commented Jan 20, 2024

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased eqy-patch-31 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout eqy-patch-31 && git pull --rebase)

@eqy
Copy link
Collaborator Author

eqy commented Feb 23, 2024

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased eqy-patch-31 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout eqy-patch-31 && git pull --rebase)

@eqy
Copy link
Collaborator Author

eqy commented Feb 27, 2024

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the eqy-patch-31 branch March 29, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cublas Problem related to cublas support open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants