Skip to content

Conversation

clee2000
Copy link
Contributor

Makes it easier to understand whats going on

Copy link

pytorch-bot bot commented Jan 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117977

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 231be70 with merge base 3c1498d (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 22, 2024
@clee2000 clee2000 changed the title Serial when NUM_PROCS is 1 [ez] Serial when NUM_PROCS is 1 Jan 22, 2024
@clee2000 clee2000 marked this pull request as ready for review January 22, 2024 21:59
@clee2000 clee2000 requested a review from a team as a code owner January 22, 2024 21:59
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! May be you also want to print the logs directly to stdout instead of file, but I guess that doesn't really matter as no one is looking that the log output interactively

@clee2000
Copy link
Contributor Author

LGTM! May be you also want to print the logs directly to stdout instead of file, but I guess that doesn't really matter as no one is looking that the log output interactively

I think the logs would end up super long again if that happened, the benefit of piping to file is both preventing interleaving and also reducing the job log size

@clee2000
Copy link
Contributor Author

@pytorchbot merge -f "no trunk needed"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the csl/num_procs_1 branch February 22, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants