Skip to content

add an option to specify custom addr2line binary #118328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

add an option to specify custom addr2line binary #118328

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d7b16e
add an option to specify custom addr2line binary
wfu-fb Jan 23, 2024
b94e6ba
minor fixes to address PR comments
wfu-fb Jan 26, 2024
6cfad68
forgot one line
wfu-fb Jan 26, 2024
8763926
more lint fixes
wfu-fb Jan 27, 2024
2b03626
finally got lintrunner fix
wfu-fb Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions torch/csrc/profiler/unwind/unwind.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,16 @@ c10::optional<std::pair<std::string, uint64_t>> libraryFor(void* addr) {
}

struct Symbolizer {
Symbolizer() {
auto envar = std::getenv("TORCH_ADDR2LINE_BINARY");
if (envar != nullptr) {
// currently we take user's input as is without checking
addr2line_binary_ = envar;
TORCH_WARN("Use custom addr2line binary: ", addr2line_binary_);
} else {
addr2line_binary_ = "addr2line"; // default
}
}
static std::lock_guard<std::mutex> guard() {
static std::mutex mutex;
return std::lock_guard<std::mutex>(mutex);
Expand Down Expand Up @@ -382,6 +392,7 @@ struct Symbolizer {

private:
static constexpr int BLOCK = 1024;
const char* addr2line_binary_;
struct Entry {
std::unique_ptr<Communicate> comm;
std::vector<void*> queried;
Expand All @@ -396,11 +407,13 @@ struct Symbolizer {
if (it == entries_.end()) {
// NOLINTNEXTLINE(*-c-arrays*)
const char* args[] = {
"addr2line", "-C", "-f", "-e", name.c_str(), nullptr};
addr2line_binary_, "-C", "-f", "-e", name.c_str(), nullptr};
it = entries_
.insert_or_assign(
name,
Entry{std::make_unique<Communicate>("addr2line", args), {}})
Entry{
std::make_unique<Communicate>(addr2line_binary_, args),
{}})
.first;
}
return it->second;
Expand Down