Skip to content

Conversation

desertfire
Copy link
Contributor

@desertfire desertfire commented Jan 31, 2024

Summary: Support ir.ComplexView in the ABI-compatible codegen

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118705

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 742b8f8 with merge base abe3c55 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@desertfire
Copy link
Contributor Author

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: Support ir.ComplexView in the ABI-compatible codegen

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

Differential Revision: [D53249039](https://our.internmc.facebook.com/intern/diff/D53249039)

[ghstack-poisoned]
@desertfire
Copy link
Contributor Author

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@desertfire
Copy link
Contributor Author

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@desertfire desertfire added the topic: not user facing topic category label Jan 31, 2024
@desertfire
Copy link
Contributor Author

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Jan 31, 2024
Summary: At some point I will stop manually adding ops to C shim, but use torchgen to generate those code. For the near term, I need to add a few more in order to switch the AOTInductor dashboard run.

Differential Revision: [D53249074](https://our.internmc.facebook.com/intern/diff/D53249074)
Pull Request resolved: #118706
Approved by: https://github.com/frank-wei, https://github.com/aakhundov
ghstack dependencies: #118704, #118705
pytorch-bot bot pushed a commit that referenced this pull request Feb 8, 2024
Summary: Support ir.ComplexView in the ABI-compatible codegen

Differential Revision: [D53249039](https://our.internmc.facebook.com/intern/diff/D53249039)
Pull Request resolved: #118705
Approved by: https://github.com/frank-wei
ghstack dependencies: #118704
pytorch-bot bot pushed a commit that referenced this pull request Feb 8, 2024
Summary: At some point I will stop manually adding ops to C shim, but use torchgen to generate those code. For the near term, I need to add a few more in order to switch the AOTInductor dashboard run.

Differential Revision: [D53249074](https://our.internmc.facebook.com/intern/diff/D53249074)
Pull Request resolved: #118706
Approved by: https://github.com/frank-wei, https://github.com/aakhundov
ghstack dependencies: #118704, #118705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants