-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[export] make spec comparison indifferent to fx collections #118718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Treat immutable_dict as dict and immutale_list as list. This behavior was tripped up by some executorch tests Differential Revision: [D53252679](https://our.internmc.facebook.com/intern/diff/D53252679/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118718
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e67f9e4 with merge base 4f5785b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dogscience
Treat immutable_dict as dict and immutale_list as list. This behavior was tripped up by some executorch tests Differential Revision: [D53252679](https://our.internmc.facebook.com/intern/diff/D53252679/) [ghstack-poisoned]
Pull Request resolved: #118718 Treat immutable_dict as dict and immutale_list as list. This behavior was tripped up by some executorch tests ghstack-source-id: 213607000 @exported-using-ghexport Differential Revision: [D53252679](https://our.internmc.facebook.com/intern/diff/D53252679/)
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Treat immutable_dict as dict and immutale_list as list. This behavior was tripped up by some executorch tests Differential Revision: [D53252679](https://our.internmc.facebook.com/intern/diff/D53252679/) Pull Request resolved: #118718 Approved by: https://github.com/zhxchen17
Stack from ghstack (oldest at bottom):
Treat immutable_dict as dict and immutale_list as list. This behavior was tripped up by some executorch tests
Differential Revision: D53252679