Skip to content

[easy] Enable test_neg_view for 5D SampleInput for torch.nn.functional.linear #118815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[easy] Enable test_neg_view for 5D SampleInput for torch.nn.functional.linear #118815

wants to merge 1 commit into from

Conversation

mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Jan 31, 2024 •
edited
Loading

@pytorch-bot pytorch-bot bot added the release notes: python_frontend python frontend release notes category label Jan 31, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 31, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118815

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7dd9b14 with merge base 6fc015f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mikaylagawarecki added a commit that referenced this pull request Jan 31, 2024
@mikaylagawarecki
[easy] Enable test_neg_view for 5D SampleInput for torch.nn.functiona…
fad8982 
…l.linear

ghstack-source-id: a02fa19
Pull Request resolved: #118815
@mikaylagawarecki mikaylagawarecki added topic: not user facing topic category and removed release notes: python_frontend python frontend release notes category labels Jan 31, 2024
malfet
malfet approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, didn't realize it was a problem with how OpInfos are generated, but makes total sense

@malfet
Copy link
Contributor

malfet commented Feb 1, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 1, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/mikaylagawarecki/182/head branch February 4, 2024 15:22
pytorch-bot bot pushed a commit that referenced this pull request Feb 8, 2024
@mikaylagawarecki @jeffdaily
[easy] Enable test_neg_view for 5D SampleInput for torch.nn.functiona…
8104e17 
…l.linear (#118815)

Fixes #117854

Pull Request resolved: #118815
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikaylagawarecki @malfet @pytorchmergebot