[DeviceMesh] Alllow 1d slice from 1d mesh #118895
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118895
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 6174702 with merge base a43c283 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
the
oncall: distributed
wz337
force-pushed
the
dummy_return_1d
branch
from
dae35b2 to
4cdf923
Compare
wz337
force-pushed
the
dummy_return_1d
branch
from
4cdf923 to
6174702
Compare
|
i was running into this today and wanted to ask someone why we didn't support it. thanks for enabling it ! |
wanchaol
approved these changes
Feb 2, 2024
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 5, 2024
The test is no longer applicable after we allow 1D slice from 1D mesh. #118895 Pull Request resolved: #119172 Approved by: https://github.com/awgu, https://github.com/atalman
pytorch-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
Fixes [ISSUE_NUMBER](#118851) i.e. mesh = init_device_mesh("cuda", (8,), mesh_dim_names=("dp")) then we do dp_mesh = mesh["dp"] should still work, just dummy return without recording parent mesh Pull Request resolved: #118895 Approved by: https://github.com/wanchaol
pytorch-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
The test is no longer applicable after we allow 1D slice from 1D mesh. #118895 Pull Request resolved: #119172 Approved by: https://github.com/awgu, https://github.com/atalman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ISSUE_NUMBER
i.e.
mesh = init_device_mesh("cuda", (8,), mesh_dim_names=("dp"))
then we do dp_mesh = mesh["dp"] should still work, just dummy return without recording parent mesh
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @tianyu-l @wconstab @yf225