Skip to content

[fix] accounting for dilation in pool padding assertion #118897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[fix] accounting for dilation in pool padding assertion #118897

wants to merge 2 commits into from

Conversation

galqiwi
Copy link
Contributor

@galqiwi galqiwi commented Feb 1, 2024 •
edited
Loading

Fixes #7541

It is a copy of #111427, as it got closed.

@galqiwi galqiwi requested a review from mruberry as a code owner February 1, 2024 19:28
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118897

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit def77f8 with merge base 124a54e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mikaylagawarecki mikaylagawarecki self-requested a review February 1, 2024 23:38
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 1, 2024
@galqiwi
Copy link
Contributor Author

galqiwi commented Feb 2, 2024

Errors in CI don't seem to be related to PR. Am I understanding this correctly?

@mikaylagawarecki
Copy link
Contributor

@pytorchbot rebase

mikaylagawarecki
mikaylagawarecki reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reopening the PR, this looks ok! Rebasing the PR to re-run CI since the base rev is 4 months old.

You might need to fix lint if you haven't already

make setup_lint and lintrunner -a from your local pytorch directory

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased main onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout main && git pull --rebase)

@galqiwi
Copy link
Contributor Author

galqiwi commented Feb 6, 2024 •
edited
Loading

Thanks for reopening the PR, this looks ok!

Glad to hear that!

You might need to fix lint if you haven't already

I have fixed it, now CI looks green

mikaylagawarecki
mikaylagawarecki approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikaylagawarecki mikaylagawarecki added module: nn Related to torch.nn release notes: nn release notes category topic: bug fixes topic category and removed module: nn Related to torch.nn labels Feb 6, 2024
@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 6, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Feb 8, 2024
@galqiwi @jeffdaily
[fix] accounting for dilation in pool padding assertion (#118897)
79d1086 
Fixes #7541

It is a copy of #111427, I have failed to fix all its issues in time, and it got closed.

Pull Request resolved: #118897
Approved by: https://github.com/mikaylagawarecki
clee2000 pushed a commit that referenced this pull request Feb 14, 2024
@galqiwi @clee2000
[fix] accounting for dilation in pool padding assertion (#118897)
4be7080 
Fixes #7541

It is a copy of #111427, I have failed to fix all its issues in time, and it got closed.

Pull Request resolved: #118897
Approved by: https://github.com/mikaylagawarecki
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nn release notes category topic: bug fixes topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Dilated max-pooling fails due to padding check

4 participants

@galqiwi @mikaylagawarecki @pytorchmergebot @pytorchbot