Skip to content

[CI] Filter should not fail if pr_body is empty #118934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[CI] Filter should not fail if pr_body is empty #118934

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Feb 1, 2024 •
edited
Loading

Otherwise it will fail with TypeError: argument of type 'NoneType' is not iterable (see https://github.com/pytorch/pytorch/actions/runs/7748725174/job/21131915226 for example)

% gh api /repos/pytorch/pytorch/issues/118927|
{
  "url": "https://api.github.com/repos/pytorch/pytorch/issues/118927",
  ...
  "body": null,
  ...
  "state_reason": null
}

TODO: Can we add a test for it?

@malfet malfet requested a review from a team as a code owner February 1, 2024 23:57
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 1, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118934

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4a9bbae with merge base dc4779b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet
Copy link
Contributor Author

malfet commented Feb 2, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 2, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor Author

malfet commented Feb 2, 2024

@pytorchbot merge -f "Lint is green"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet mentioned this pull request Feb 2, 2024
Closed
pytorch-bot bot pushed a commit that referenced this pull request Feb 8, 2024
@malfet @jeffdaily
[CI] Filter should not fail if pr_body is empty (#118934)
1d61837 
Otherwise it will fail with `TypeError: argument of type 'NoneType' is not iterable` (see https://github.com/pytorch/pytorch/actions/runs/7748725174/job/21131915226 for example)

```
% gh api /repos//issues/118927|
{
  "url": "https://api.github.com/repos/pytorch/pytorch/issues/118927",
  ...
  "body": null,
  ...
  "state_reason": null
}
```

TODO: Can we add a test for it?
Pull Request resolved: #118934
Approved by: https://github.com/clee2000, https://github.com/seemethere, https://github.com/huydhn
@github-actions github-actions bot deleted the malfet-patch-11 branch March 4, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@seemethere seemethere seemethere approved these changes

@clee2000 clee2000 clee2000 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @pytorchmergebot @huydhn @seemethere @clee2000