Skip to content

Inline gradcheck functions since they don't have C bindings #119047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Inline gradcheck functions since they don't have C bindings #119047

wants to merge 3 commits into from

Conversation

jamesjwu
Copy link
Contributor

@jamesjwu jamesjwu commented Feb 2, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Gradcheck functions are in python, so they shouldn't be in torch_c_binding_in_graph_functions
fixes #118792

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119047

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4affba7 with merge base 65314a6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jamesjwu jamesjwu marked this pull request as draft February 2, 2024 17:55
@jamesjwu jamesjwu added the keep-going Don't stop on first failure, keep running tests until the end label Feb 2, 2024
@jamesjwu jamesjwu changed the title Catch NotImplementedError when proxying torch.* functions that return unproxyable values Don't treat as_sparse_autograd as node and graph break on sparse_coo_tensor Feb 2, 2024
@jamesjwu jamesjwu changed the title Don't treat as_sparse_autograd as node and graph break on sparse_coo_tensor Trace through torch.sparse.as_sparse_gradcheck and graph break on sparse_coo_tensor Feb 2, 2024
@jamesjwu jamesjwu changed the title Trace through torch.sparse.as_sparse_gradcheck and graph break on sparse_coo_tensor Inline gradcheck functions since they don't have C bindings Feb 2, 2024
@jamesjwu jamesjwu marked this pull request as ready for review February 2, 2024 19:41
yanboliang
yanboliang approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@yanboliang yanboliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping improve tracing rule quality!

@jamesjwu jamesjwu added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 2, 2024
@jamesjwu
Catch NotImplementedError when proxying torch.* functions that return…
404cef7 
… unproxyable values

ghstack-source-id: c1001a0
Pull Request resolved: #119047
@jamesjwu jamesjwu force-pushed the gh/jamesjwu/10/base branch from 88fa191 to c908caf Compare February 2, 2024 22:52
@jamesjwu jamesjwu force-pushed the gh/jamesjwu/10/head branch from 4e4d2ca to 404cef7 Compare February 2, 2024 22:54
@jamesjwu
Update on "Inline gradcheck functions since they don't have C bindings"
53cc601 

Gradcheck functions are in python, so they shouldn't be in `torch_c_binding_in_graph_functions`
fixes #118792


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@jamesjwu
Copy link
Contributor Author

jamesjwu commented Feb 3, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@jamesjwu jamesjwu added the topic: not user facing topic category label Feb 3, 2024
@jamesjwu
Copy link
Contributor Author

jamesjwu commented Feb 3, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 11 jobs have failed, first few of them are: pull / linux-focal-py3.8-clang10 / test (default, 2, 3, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (crossref, 2, 2, linux.2xlarge), pull / linux-jammy-py3.10-clang15-asan / test (default, 5, 6, linux.4xlarge), pull / linux-focal-py3.11-clang10 / test (default, 1, 3, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (crossref, 2, 2, linux.2xlarge)

Details for Dev Infra team Raised by workflow job

@jamesjwu
Copy link
Contributor Author

jamesjwu commented Feb 3, 2024

@pytorchbot merge -f "Tests pass locally, failures are on broken trunk"

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: PR 119047 is out of sync with the corresponding revision 01005aecd8a76b9ac1d8b6e274d105ecfc987cfe on branch gh/jamesjwu/10/orig that would be merged into main. This usually happens because there is a non ghstack change in the PR. Please sync them and try again (ex. make the changes on origin/gh/jamesjwu/10/orig and run ghstack).

Details for Dev Infra team Raised by workflow job

@jamesjwu
Update on "Inline gradcheck functions since they don't have C bindings"
4affba7 

Gradcheck functions are in python, so they shouldn't be in `torch_c_binding_in_graph_functions`
fixes #118792


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
jamesjwu added a commit that referenced this pull request Feb 3, 2024
@jamesjwu
Catch NotImplementedError when proxying torch.* functions that return…
78db13d 
… unproxyable values

ghstack-source-id: 1eb1af1
Pull Request resolved: #119047
@jamesjwu
Copy link
Contributor Author

jamesjwu commented Feb 3, 2024

@pytorchbot merge -f "Tests pass locally, failures are on broken trunk"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Feb 8, 2024
@jamesjwu @jeffdaily
Inline gradcheck functions since they don't have C bindings (#119047)
35fc7be 
Gradcheck functions are in python, so they shouldn't be in `torch_c_binding_in_graph_functions`
fixes #118792

Pull Request resolved: #119047
Approved by: https://github.com/yanboliang, https://github.com/zou3519
@github-actions github-actions bot deleted the gh/jamesjwu/10/head branch March 5, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

+1 more reviewer

@yanboliang yanboliang yanboliang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamesjwu @pytorchmergebot @yanboliang @zou3519