Skip to content

Update vmap guard to avoid recompilations #119061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Update vmap guard to avoid recompilations #119061

wants to merge 17 commits into from

Conversation

guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented Feb 2, 2024 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119061

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 91a8734 with merge base c0e5cca (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

guilhermeleobas added a commit that referenced this pull request Feb 2, 2024
@guilhermeleobas
Update vmap guard to avoid recompilations
fa619f6 
ghstack-source-id: 09ab88f
Pull Request resolved: #119061
@guilhermeleobas
Copy link
Collaborator Author

Fixes #118493

zou3519
zou3519 reviewed Feb 5, 2024
View reviewed changes
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
081247e 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Feb 5, 2024
@guilhermeleobas
Update vmap guard to avoid recompilations
234c344 
ghstack-source-id: 33d43f7
Pull Request resolved: #119061
@guilhermeleobas guilhermeleobas mentioned this pull request Feb 5, 2024
Closed
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
0aa2505 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
e83e705 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
zou3519
zou3519 reviewed Feb 6, 2024
View reviewed changes
zou3519
zou3519 reviewed Feb 6, 2024
View reviewed changes
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
52609ff 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
b6d1aa8 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
5a409f5 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
10d9e5f 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request Feb 7, 2024
Closed
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
a6c2462 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
zou3519
zou3519 reviewed Feb 8, 2024
View reviewed changes
zou3519
zou3519 reviewed Feb 8, 2024
View reviewed changes
zou3519
zou3519 reviewed Feb 8, 2024
View reviewed changes
zou3519
zou3519 reviewed Feb 8, 2024
View reviewed changes
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
b420d61 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
3b82e0f 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
0820754 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
a920686 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
zou3519
zou3519 reviewed Feb 9, 2024
View reviewed changes
zou3519
zou3519 reviewed Feb 9, 2024
View reviewed changes
zou3519
zou3519 reviewed Feb 9, 2024
View reviewed changes
zou3519
zou3519 reviewed Feb 9, 2024
View reviewed changes
zou3519
zou3519 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please read comments: GradInterpreter's state has a prev_grad_mode in it and we probably still want to add a guard if the functorch stack is empty

@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
7bc5167 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
e7ebb16 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
5d07ed8 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@guilhermeleobas
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 13, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@guilhermeleobas
Update on "Update vmap guard to avoid recompilations"
91a8734 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@guilhermeleobas
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@guilhermeleobas guilhermeleobas mentioned this pull request Mar 12, 2024
Closed
@github-actions github-actions bot deleted the gh/guilhermeleobas/21/head branch March 15, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guilhermeleobas @pytorchmergebot @zou3519 @pytorchbot