Skip to content

[mypy] added type annotations to codegen_nodes methods #119080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[mypy] added type annotations to codegen_nodes methods #119080

wants to merge 2 commits into from

Conversation

@chenyang78
Copy link
Contributor

@chenyang78 chenyang78 commented Feb 2, 2024 •
edited by pytorch-bot bot
Loading

@chenyang78
[mypy] added type annotations to codegen_nodes methods
0f868db 
added correct type annotations to scheduler and backends'
codegen_nodes methods

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119080

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5e27d24 with merge base 0348975 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

chenyang78 added a commit that referenced this pull request Feb 2, 2024
@chenyang78
[mypy] added type annotations to codegen_nodes methods
d47b4c7 
added correct type annotations to scheduler and backends'
codegen_nodes methods

ghstack-source-id: 93bd4c2
Pull Request resolved: #119080
@chenyang78 chenyang78 requested review from eellison and int3 February 2, 2024 22:09
@chenyang78 chenyang78 added the topic: not user facing topic category label Feb 3, 2024
@chenyang78
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 4, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 11 jobs have failed, first few of them are: pull / linux-focal-py3.11-clang10 / test (default, 2, 3, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (crossref, 2, 2, linux.2xlarge), pull / linux-jammy-py3.8-gcc11 / test (default, 2, 3, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (default, 2, 3, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (crossref, 1, 2, linux.2xlarge)

Details for Dev Infra team Raised by workflow job

@chenyang78
Update on "[mypy] added type annotations to codegen_nodes methods"
5e27d24 
added correct type annotations to scheduler and backends'
codegen_nodes methods

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
chenyang78 added a commit that referenced this pull request Feb 5, 2024
@chenyang78
[mypy] added type annotations to codegen_nodes methods
4f38516 
added correct type annotations to scheduler and backends'
codegen_nodes methods

ghstack-source-id: 775e373
Pull Request resolved: #119080
@chenyang78
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Feb 8, 2024
@chenyang78 @jeffdaily
[mypy] added type annotations to codegen_nodes methods (#119080)
470fedc 
added correct type annotations to scheduler and backends'
codegen_nodes methods

Pull Request resolved: #119080
Approved by: https://github.com/eellison
@github-actions github-actions bot deleted the gh/chenyang78/3/head branch March 7, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

@int3 int3 Awaiting requested review from int3

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chenyang78 @pytorchmergebot @eellison