Increase recommended logging in DEFAULT_LOGGING #119207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For long running batch jobs, it is best to opt for logs that are too spammy rather than not spammy enough. This lines up DEFAULT_LOGGING with our current internal guidance at Meta. Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119207
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a663814 with merge base ab613a4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh and
miladm
bdhirsh
reviewed
Feb 5, 2024
| "recompiles": True, | ||
| "dynamic": logging.INFO, | ||
| "guards": True, | ||
| "trace_source": True, |
There was a problem hiding this comment.
I'm not familiar with trace_source - are you taking it out because it's covered by dynamo's debug logging?
There was a problem hiding this comment.
Yup. Ditto with guards and the other one.
bdhirsh
approved these changes
Feb 5, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorch-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
For long running batch jobs, it is best to opt for logs that are too spammy rather than not spammy enough. This lines up DEFAULT_LOGGING with our current internal guidance at Meta. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #119207 Approved by: https://github.com/bdhirsh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
For long running batch jobs, it is best to opt for logs that are too
spammy rather than not spammy enough. This lines up DEFAULT_LOGGING
with our current internal guidance at Meta.
Signed-off-by: Edward Z. Yang ezyang@meta.com