Skip to content

Conversation

wangjiangben-hw
Copy link
Contributor

@wangjiangben-hw wangjiangben-hw commented Feb 6, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119268

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit abc8614 with merge base 389b56b (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 6, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 6, 2024

Please seek CI approval before scheduling CIFlow labels

@cpuhrsch cpuhrsch requested a review from ezyang February 8, 2024 18:56
@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 8, 2024
@ezyang ezyang requested review from EikanWang, jansel and jgong5 and removed request for ezyang February 9, 2024 03:43
@ezyang
Copy link
Contributor

ezyang commented Feb 9, 2024

Reassigning to the authors/reviewers of the code being modified

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 17, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 17, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 17, 2024

Please seek CI approval before scheduling CIFlow labels

@wangjiangben-hw
Copy link
Contributor Author

cc @ezyang @jansel @jgong5 @EikanWang

jansel
jansel previously approved these changes Feb 17, 2024
@wangjiangben-hw
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@wangjiangben-hw
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@wangjiangben-hw
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@wangjiangben-hw
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit to wangjiangben-hw/pytorch that referenced this pull request Feb 22, 2024
Fixes pytorch#119267

Currently https://github.com/pytorch/pytorch/blob/main/torch/_inductor/codegen/common.py#L106 only supports built-in device function, I'm going to add a register function to get overrides class.

Pull Request resolved: pytorch#119268
Approved by: https://github.com/jansel
pytorchmergebot pushed a commit to wangjiangben-hw/pytorch that referenced this pull request Feb 22, 2024
pytorchmergebot added a commit to wangjiangben-hw/pytorch that referenced this pull request Feb 22, 2024
This reverts commit d9d0f1d.

Reverted pytorch#120207 on behalf of https://github.com/atalman due to Broke inductor tests ([comment](pytorch#120207 (comment)))
pytorchmergebot added a commit to wangjiangben-hw/pytorch that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor oncall: pt2 open source Reverted topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Registers DeviceOpOverrides for a device and obtains the corresponding class using the get function.

8 participants