Skip to content

Fix optim.lr_scheduler examples in doc to use optimizer vs self.opt #119563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix optim.lr_scheduler examples in doc to use optimizer vs self.opt #119563

wants to merge 1 commit into from

Conversation

kuraga
Copy link
Contributor

@kuraga kuraga commented Feb 9, 2024

Fixes #119561

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119563

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a038584 with merge base 90dabff (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kuraga kuraga mentioned this pull request Feb 9, 2024
Closed
janeyx99
janeyx99 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@janeyx99 janeyx99 changed the title fix optim.lr_scheduler examples (#119561) Fix optim.lr_scheduler examples in doc to use optimizer vs self.opt Feb 9, 2024
@janeyx99 janeyx99 added the topic: docs topic category label Feb 9, 2024
@janeyx99
Copy link
Contributor

janeyx99 commented Feb 9, 2024

Hm weird...the normal PR jobs aren't triggering. We should verify the docs look good before merging.

@janeyx99
Copy link
Contributor

janeyx99 commented Feb 9, 2024

@clee2000 do you know why the jobs aren't getting triggered?

@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 9, 2024
@clee2000
Copy link
Contributor

clee2000 commented Feb 9, 2024 •
edited
Loading

@clee2000 do you know why the jobs aren't getting triggered?

The commit title contains [ci skip] https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs. You'll need to make another commit without that to trigger pull_request CI

@kuraga
Copy link
Contributor Author

kuraga commented Feb 9, 2024

Is CI needed for docs regeneration?

Can I force-push the commit?

@janeyx99
Copy link
Contributor

janeyx99 commented Feb 9, 2024

Yes, we have a docs build that depends on building torch, so could you recommit without the skip ci message? Yes, forcepushing would work.

@kuraga
Copy link
Contributor Author

kuraga commented Feb 9, 2024

@janeyx99 , done.

@albanD albanD removed their request for review February 9, 2024 21:19
@janeyx99 janeyx99 added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 10, 2024
@janeyx99
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kuraga kuraga deleted the torch.optim.lr_scheduler-fix-examples branch February 10, 2024 15:12
clee2000 pushed a commit that referenced this pull request Feb 14, 2024
@kuraga @clee2000
Fix optim.lr_scheduler examples in doc to use optimizer vs self.opt (#…
fccfe00 
…119563)

Fixes #119561

Pull Request resolved: #119563
Approved by: https://github.com/janeyx99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: optim topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.optim.lr_scheduler examples use self.opt instead of optimizer

5 participants

@kuraga @janeyx99 @clee2000 @pytorchmergebot @pytorchbot