Skip to content

Size oblivious test for slice optimization #119625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Size oblivious test for slice optimization #119625

wants to merge 2 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Feb 10, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Fixes #119623

Signed-off-by: Edward Z. Yang ezyang@meta.com

@ezyang
Size oblivious test for slice optimization
3d78593 
Fixes #119623

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119625

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5c9ef41 with merge base a82c507 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Feb 10, 2024
@ezyang
Size oblivious test for slice optimization
595a8d9 
Fixes #119623

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: b1c933f
Pull Request resolved: #119625
@ezyang
Update on "Size oblivious test for slice optimization"
5c9ef41 
Fixes #119623

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
@ezyang ezyang added release notes: composability release notes category topic: bug fixes topic category labels Feb 13, 2024
ezyang added a commit that referenced this pull request Feb 13, 2024
@ezyang
Size oblivious test for slice optimization
e26d02d 
Fixes #119623

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: c29cb30
Pull Request resolved: #119625
@ezyang
Copy link
Contributor Author

ezyang commented Feb 13, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 13, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

bdhirsh
bdhirsh reviewed Feb 14, 2024
View reviewed changes
aten/src/ATen/TensorIndexing.h
if (!disable_slice_optimization && start == 0 && length == stop &&
if (!disable_slice_optimization &&
TORCH_GUARD_SIZE_OBLIVIOUS(start.sym_eq(0)) && length == stop &&
step == 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curiosity q: I would naively have thought that we'll (eventually) need the same treatment for step == 1 here. Is that wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear. This could only matter if you had an unbacked SymInt specifying your step... which is a hard situation to imagine. (But yes, if it was unbacked, then making the guard here oblivious would be profitable.)

@github-actions github-actions bot deleted the gh/ezyang/2568/head branch March 16, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdhirsh bdhirsh bdhirsh left review comments

@albanD albanD albanD approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: composability release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @pytorchmergebot @albanD @bdhirsh