[quant][pt2e] Add `model_is_exported` util function #119726

andrewor14 · 2024-02-12T23:05:44Z

Stack from ghstack (oldest at bottom):

-> [quant][pt2e] Add model_is_exported util function #119726

Summary: This commit adds the model_is_exported util function
for users to be able to easily tell what APIs to call to move
their models between train and eval modes. This has the
additional advantage of hiding the implementation of how we
detect a model is exported, in case the metadata format changes
in the future.

Test Plan:
python test/test_quantization.py TestQuantizePT2E.test_model_is_exported

Differential Revision: D53812972

Summary: This commit adds the `model_is_exported` util function for users to be able to easily tell what APIs to call to move their models between train and eval modes. This has the additional advantage of hiding the implementation of how we detect a model is exported, in case the metadata format changes in the future. Test Plan: python test/test_quantization.py TestQuantizePT2E.test_model_is_exported [ghstack-poisoned]

pytorch-bot · 2024-02-12T23:05:48Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119726

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 676c929 with merge base 65fd8b6 ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-py3.8-clang10-onnx / test (default, 2, 2, linux.2xlarge) (gh)
onnx/test_fx_to_onnx_with_onnxruntime.py::TestFxToOnnxWithOnnxRuntime_op_level_debug_True_dynamic_shapes_False_model_type_TorchModelType.TORCH_EXPORT_EXPORTEDPROGRAM::test_squeeze_runtime_dim

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Summary: This commit adds the `model_is_exported` util function for users to be able to easily tell what APIs to call to move their models between train and eval modes. This has the additional advantage of hiding the implementation of how we detect a model is exported, in case the metadata format changes in the future. Test Plan: python test/test_quantization.py TestQuantizePT2E.test_model_is_exported ghstack-source-id: ef39eae Pull Request resolved: #119726

Summary: This commit adds the `model_is_exported` util function for users to be able to easily tell what APIs to call to move their models between train and eval modes. This has the additional advantage of hiding the implementation of how we detect a model is exported, in case the metadata format changes in the future. Test Plan: python test/test_quantization.py TestQuantizePT2E.test_model_is_exported [ghstack-poisoned]

Summary: This commit adds the `model_is_exported` util function for users to be able to easily tell what APIs to call to move their models between train and eval modes. This has the additional advantage of hiding the implementation of how we detect a model is exported, in case the metadata format changes in the future. Test Plan: python test/test_quantization.py TestQuantizePT2E.test_model_is_exported ghstack-source-id: bbcfb68 Pull Request resolved: #119726

andrewor14 · 2024-02-14T20:16:33Z

@pytorchbot rebase

pytorchmergebot · 2024-02-14T20:18:16Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

Summary: This commit adds the `model_is_exported` util function for users to be able to easily tell what APIs to call to move their models between train and eval modes. This has the additional advantage of hiding the implementation of how we detect a model is exported, in case the metadata format changes in the future. Test Plan: python test/test_quantization.py TestQuantizePT2E.test_model_is_exported [ghstack-poisoned]

pytorchmergebot · 2024-02-14T20:18:27Z

Successfully rebased gh/andrewor14/54/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/119726)

Summary: This commit adds the `model_is_exported` util function for users to be able to easily tell what APIs to call to move their models between train and eval modes. This has the additional advantage of hiding the implementation of how we detect a model is exported, in case the metadata format changes in the future. Test Plan: python test/test_quantization.py TestQuantizePT2E.test_model_is_exported ghstack-source-id: 1fd1c11 Pull Request resolved: #119726

andrewor14 · 2024-02-15T16:00:55Z

@andrewor14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

andrewor14 · 2024-02-15T16:01:22Z

@pytorchbot merge

pytorchmergebot · 2024-02-15T16:04:43Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

albanD · 2024-02-15T16:36:53Z

docs/source/conf.py

    "node_arg_is_weight",
    "return_arg_list",
+    # torch.ao.quantization.pt2e.export_utils
+    "model_is_exported",


Adding new entries in this file is not ok.
Please properly document this API so that it appears properly on the website. Or make it private

pytorchmergebot · 2024-02-15T16:37:49Z

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

Summary: This commit adds the `model_is_exported` util function for users to be able to easily tell what APIs to call to move their models between train and eval modes. This has the additional advantage of hiding the implementation of how we detect a model is exported, in case the metadata format changes in the future. Test Plan: python test/test_quantization.py TestQuantizePT2E.test_model_is_exported Differential Revision: [D53812972](https://our.internmc.facebook.com/intern/diff/D53812972) [ghstack-poisoned]

Summary: This commit adds the `model_is_exported` util function for users to be able to easily tell what APIs to call to move their models between train and eval modes. This has the additional advantage of hiding the implementation of how we detect a model is exported, in case the metadata format changes in the future. Test Plan: python test/test_quantization.py TestQuantizePT2E.test_model_is_exported ghstack-source-id: a0b4008 Pull Request resolved: #119726

andrewor14 · 2024-02-15T21:53:54Z

@andrewor14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: This commit adds the `model_is_exported` util function for users to be able to easily tell what APIs to call to move their models between train and eval modes. This has the additional advantage of hiding the implementation of how we detect a model is exported, in case the metadata format changes in the future. Test Plan: python test/test_quantization.py TestQuantizePT2E.test_model_is_exported Differential Revision: [D53812972](https://our.internmc.facebook.com/intern/diff/D53812972) [ghstack-poisoned]

andrewor14 · 2024-02-16T03:33:12Z

@andrewor14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: This commit adds the `model_is_exported` util function for users to be able to easily tell what APIs to call to move their models between train and eval modes. This has the additional advantage of hiding the implementation of how we detect a model is exported, in case the metadata format changes in the future. Test Plan: python test/test_quantization.py TestQuantizePT2E.test_model_is_exported Differential Revision: [D53812972](https://our.internmc.facebook.com/intern/diff/D53812972) [ghstack-poisoned]

Summary: This commit adds the `model_is_exported` util function for users to be able to easily tell what APIs to call to move their models between train and eval modes. This has the additional advantage of hiding the implementation of how we detect a model is exported, in case the metadata format changes in the future. Test Plan: python test/test_quantization.py TestQuantizePT2E.test_model_is_exported ghstack-source-id: 9f4b37d Pull Request resolved: #119726

andrewor14 · 2024-02-16T15:47:58Z

@andrewor14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

albanD

SGTM!
Thanks for the update

andrewor14 · 2024-02-16T19:27:14Z

@pytorchbot merge

pytorchmergebot · 2024-02-16T19:29:14Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

andrewor14 requested a review from jerryzh168 as a code owner February 12, 2024 23:05

andrewor14 mentioned this pull request Feb 12, 2024

[quant][pt2e][be] Rename eval_utils -> export_utils #119725

Closed

pytorch-bot bot added the release notes: quantization release notes category label Feb 12, 2024

andrewor14 requested a review from tugsbayasgalan February 12, 2024 23:06

tugsbayasgalan approved these changes Feb 13, 2024

View reviewed changes

andrewor14 requested a review from albanD as a code owner February 14, 2024 16:33

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 15, 2024

pytorchmergebot added the merging label Feb 15, 2024

albanD requested changes Feb 15, 2024

View reviewed changes

andrewor14 requested a review from albanD February 16, 2024 03:33

albanD approved these changes Feb 16, 2024

View reviewed changes

pytorchmergebot closed this in 6ea4480 Feb 16, 2024

pytorchmergebot added Merged and removed merging labels Feb 16, 2024

github-actions bot deleted the gh/andrewor14/54/head branch March 18, 2024 01:51

[quant][pt2e] Add model_is_exported util function #119726

[quant][pt2e] Add model_is_exported util function #119726

Uh oh!

Conversation

andrewor14 commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119726

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

andrewor14 commented Feb 14, 2024

Uh oh!

pytorchmergebot commented Feb 14, 2024

Uh oh!

pytorchmergebot commented Feb 14, 2024

Uh oh!

andrewor14 commented Feb 15, 2024

Uh oh!

andrewor14 commented Feb 15, 2024

Uh oh!

pytorchmergebot commented Feb 15, 2024

Merge started

Uh oh!

albanD Feb 15, 2024

Choose a reason for hiding this comment

Uh oh!

pytorchmergebot commented Feb 15, 2024

Uh oh!

andrewor14 commented Feb 15, 2024

Uh oh!

andrewor14 commented Feb 16, 2024

Uh oh!

andrewor14 commented Feb 16, 2024

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

andrewor14 commented Feb 16, 2024

Uh oh!

pytorchmergebot commented Feb 16, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[quant][pt2e] Add `model_is_exported` util function #119726

[quant][pt2e] Add `model_is_exported` util function #119726

andrewor14 commented Feb 12, 2024 •

edited

Loading

pytorch-bot bot commented Feb 12, 2024 •

edited

Loading