Skip to content

Conversation

eellison
Copy link
Contributor

@eellison eellison commented Feb 13, 2024

Copy link

pytorch-bot bot commented Feb 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119739

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e30519d with merge base 52a3de6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

eellison added a commit that referenced this pull request Feb 13, 2024
ghstack-source-id: d430cb1
Pull Request resolved: #119739
@eellison eellison requested a review from ezyang February 13, 2024 01:22
@eellison eellison added the topic: not user facing topic category label Feb 13, 2024
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 13, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ezyang
Copy link
Contributor

ezyang commented Feb 13, 2024

By the way, while you're in here, it would be nice if we saved the CompileId that produced this cuda graph and report it here. Because cuda graph recording only happens at runtime, the regular trace context is no longer set, so these log entries don't get [0/0] annotation.

@github-actions github-actions bot deleted the gh/eellison/595/head branch March 15, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants