Skip to content

Conversation

mengluy0125
Copy link
Contributor

@mengluy0125 mengluy0125 commented Feb 20, 2024

Summary: Normalize unbind nodes for the followup split_cat pattern detection and node removals

Test Plan:

buck2 test //caffe2/test/inductor:split_cat_fx_passes

Buck UI: https://www.internalfb.com/buck2/f42297c2-2595-40a2-b270-5cec026f2fe4
Test UI: https://www.internalfb.com/intern/testinfra/testrun/17451448578242323
Network: Up: 132KiB Down: 88KiB (reSessionID-fc725143-317a-42a9-bc7e-0bbab6ef9e5c)
Jobs completed: 27. Time elapsed: 3:09.2s.
Cache hits: 0%. Commands: 1 (cached: 0, remote: 0, local: 1)
Tests finished: Pass 11. Fail 0. Fatal 0. Skip 0. Build failure 0

buck2 test mode/opt mode/inplace caffe2/test/inductor/fb:test_split_cat_fx_passes_aten_fb

Differential Revision: D53964593

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120253

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 36a3a45 with merge base 8fa6340 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53964593

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53964593

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53964593

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53964593

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53964593

Summary:

Normalize unbind nodes for the followup split_cat pattern detection and node removals

Test Plan:
```
buck2 test //caffe2/test/inductor:split_cat_fx_passes
```
Buck UI: https://www.internalfb.com/buck2/ef1ad6f9-081f-4d59-8395-902f54d01bd2
Test UI: https://www.internalfb.com/intern/testinfra/testrun/9288674253991279
Network: Up: 45MiB  Down: 280MiB  (reSessionID-f99e5a4d-8ce5-497d-aa82-0c460a529f6c)
Jobs completed: 28. Time elapsed: 3:34.8s.
Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2)
Tests finished: Pass 10. Fail 0. Fatal 0. Skip 1. Build failure 0

```
buck2 run mode/inplace caffe2/test/inductor/fb:test_split_cat_fx_passes_aten_fb
```
Ran 13 tests in 870.512s

OK

Differential Revision: D53964593
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53964593

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 23, 2024
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants