Skip to content

Add meta device support to sparse compressed tensors #120498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add meta device support to sparse compressed tensors #120498

wants to merge 2 commits into from

Conversation

pearu
Copy link
Collaborator

@pearu pearu commented Feb 23, 2024 •
edited
Loading

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Feb 23, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120498

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit d6b7c66 with merge base 54c1cf8 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pearu added a commit that referenced this pull request Feb 23, 2024
@pearu
Add meta device support to sparse compressed tensors
1cae320 
ghstack-source-id: 1d8ba92
Pull Request resolved: #120498
@pearu pearu marked this pull request as draft February 23, 2024 17:05
@pearu pearu added open source topic: new features topic category module: sparse Related to torch.sparse labels Feb 23, 2024
@pearu pearu mentioned this pull request Feb 23, 2024
Closed
@aartbik
Copy link
Collaborator

aartbik commented Feb 23, 2024

Thank you so much for doing this so quickly. Much appreciated!

@pearu pearu requested a review from ezyang February 24, 2024 10:17
@pearu pearu marked this pull request as ready for review February 24, 2024 10:18
@pearu
Update on "Add meta device support to sparse compressed tensors"
d6b7c66 
As in the title.

Unblocks #117907 (comment)




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
@pearu pearu mentioned this pull request Feb 24, 2024
Closed
ezyang
ezyang reviewed Feb 24, 2024
View reviewed changes
c10/core/DispatchKey.h
// See [Note: Per-Backend Functionality Dispatch Keys]
Sparse,

// TODO: Make SparseCsr a functionality key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang do you think it is worth addressing this TODO item as a follow-up? What are the main benefits of doing this earlier rather than later?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a BE thing. Matters more when we run out of dispatch keys

ezyang
ezyang approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, very slick

@ezyang ezyang mentioned this pull request Feb 24, 2024
Closed
@pearu
Copy link
Collaborator Author

pearu commented Feb 25, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 25, 2024
@pearu pearu self-assigned this Feb 25, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pearu pearu mentioned this pull request Feb 25, 2024
Closed
@zou3519
Copy link
Contributor

zou3519 commented Feb 26, 2024

This broke CI, see https://github.com/pytorch/pytorch/actions/runs/8039434113/job/21964058543 for example logs

@zou3519
Copy link
Contributor

zou3519 commented Feb 26, 2024

@pytorchbot revert -m "broke CI" -c ignoredsignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Feb 26, 2024
@pytorchmergebot
Revert "Add meta device support to sparse compressed tensors (#120498)"
8a32a07 
This reverts commit 5d71ba6.

Reverted #120498 on behalf of https://github.com/zou3519 due to broke CI ([comment](#120498 (comment)))
@pytorchmergebot
Copy link
Collaborator

@pearu your PR has been successfully reverted.

@zou3519 zou3519 added the keep-going Don't stop on first failure, keep running tests until the end label Feb 26, 2024
@pearu pearu marked this pull request as draft February 27, 2024 10:02
This was referenced Feb 27, 2024
Closed
Closed
pearu added a commit that referenced this pull request Feb 27, 2024
@pearu
Update on "Add sparse compressed meta tensor support"
95d5b97 
Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
@pearu
Copy link
Collaborator Author

pearu commented Feb 27, 2024

The PR will be abandon in favor of #120707

pearu added a commit that referenced this pull request Feb 27, 2024
@pearu
Update on "Add sparse compressed meta tensor support"
606b1af 
Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
@Shan19900305 Shan19900305 mentioned this pull request Feb 28, 2024
Closed
pearu added a commit that referenced this pull request Feb 28, 2024
@pearu
Update base for Update on "Add sparse compressed meta tensor support"
89394d9 
Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Feb 28, 2024
@pearu
Update on "Add sparse compressed meta tensor support"
d2c43a3 
Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Feb 28, 2024
@pearu
Update base for Update on "Add sparse compressed meta tensor support"
a934d7e 
Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Feb 28, 2024
@pearu
Update on "Add sparse compressed meta tensor support"
a75258b 
Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Feb 28, 2024
@pearu
Update base for Update on "Add sparse compressed meta tensor support"
5e3d3ce 
Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Feb 28, 2024
@pearu
Update on "Add sparse compressed meta tensor support"
f3351e9 
Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Feb 28, 2024
@pearu
Update base for Update on "Add sparse compressed meta tensor support"
5831fa2 
As in the title.

Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Feb 28, 2024
@pearu
Update on "Add sparse compressed meta tensor support"
eb2de95 
As in the title.

Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Feb 29, 2024
@pearu
Update base for Update on "Add sparse compressed meta tensor support"
a6afdd6 
As in the title.

Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Feb 29, 2024
@pearu
Update on "Add sparse compressed meta tensor support"
3798a28 
As in the title.

Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Mar 1, 2024
@pearu
Update base for Update on "Add sparse compressed meta tensor support"
5ec47fe 
As in the title.

Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Mar 1, 2024
@pearu
Update on "Add sparse compressed meta tensor support"
ae05982 
As in the title.

Replaces #120498 and #120562 




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Mar 1, 2024
@pearu @pytorchmergebot
Add sparse compressed meta tensor support (#120707)
b8e6ca6 
As in the title.

Replaces #120498 and #120562

Pull Request resolved: #120707
Approved by: https://github.com/ezyang
ghstack dependencies: #120703
@pearu
Copy link
Collaborator Author

pearu commented Mar 1, 2024

Closing as #120707 has landed.

@pearu pearu closed this Mar 1, 2024
@github-actions github-actions bot deleted the gh/pearu/118/head branch April 1, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

@pearu pearu

Labels

ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged module: sparse Related to torch.sparse open source release notes: sparse release notes category Reverted topic: new features topic category

Projects

Sparse tensors
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pearu @aartbik @pytorchmergebot @zou3519 @ezyang