-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ROCm] enable complex128 in test_addmm_sizes_all_sparse_csr for rocm for trivial (k,n,m) cases #120504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120504
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit a89389d with merge base 605c0a2 ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Please seek CI approval before scheduling CIFlow labels |
Please seek CI approval before scheduling CIFlow labels |
Please seek CI approval before scheduling CIFlow labels |
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
39ac71d
to
0e68735
Compare
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
2380b9b
to
d59d1d3
Compare
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
c664b9a
to
4acb354
Compare
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
1f0b8de
to
ad94b88
Compare
All tests passed. 19 tests enabled for ROCm #120504 (comment) |
@malfet Please review and merge this PR, it's enabling some trivial cases for sparse unit tests for ROCm6.0 and above. CI passed: #120504 (comment) |
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
ad94b88
to
3c23f98
Compare
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
3c23f98
to
a89389d
Compare
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This PR enables
test_addmm_sizes_all_sparse_csr_k_*_n_*_m_*_cuda_complex128
for ROCm for trivial cases (m or n or k = 0)CUSPARSE_SPMM_COMPLEX128_SUPPORTED also used for
test_addmm_all_sparse_csr
andtest_sparse_matmul
and both of them are skipped for ROCm by@skipIfRocm
or@skipCUDAIf(not _check_cusparse_spgemm_available())
cc: @jithunnair-amd
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang