Skip to content

Conversation

dnikolaev-amd
Copy link
Contributor

@dnikolaev-amd dnikolaev-amd commented Feb 23, 2024

This PR enables test_addmm_sizes_all_sparse_csr_k_*_n_*_m_*_cuda_complex128 for ROCm for trivial cases (m or n or k = 0)

CUSPARSE_SPMM_COMPLEX128_SUPPORTED also used for test_addmm_all_sparse_csr and test_sparse_matmul and both of them are skipped for ROCm by @skipIfRocm or @skipCUDAIf(not _check_cusparse_spgemm_available())

cc: @jithunnair-amd

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Feb 23, 2024
Copy link

pytorch-bot bot commented Feb 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120504

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a89389d with merge base 605c0a2 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

pytorch-bot bot commented Feb 23, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/rocm Trigger "default" config CI on ROCm label Feb 23, 2024
@dnikolaev-amd dnikolaev-amd changed the title enable complex128 in test_addmm_sizes_all_sparse_csr for rocm for trivial (k,n,m) cases [ROCm] enable complex128 in test_addmm_sizes_all_sparse_csr for rocm for trivial (k,n,m) cases Feb 23, 2024
@pytorch-bot pytorch-bot bot added the ciflow/rocm Trigger "default" config CI on ROCm label Feb 23, 2024
Copy link

pytorch-bot bot commented Feb 23, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/rocm Trigger "default" config CI on ROCm label Feb 23, 2024
@jeffdaily jeffdaily added the ciflow/rocm Trigger "default" config CI on ROCm label Feb 23, 2024
Copy link

pytorch-bot bot commented Feb 23, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/rocm Trigger "default" config CI on ROCm label Feb 23, 2024
@jeffdaily jeffdaily added the ciflow/rocm Trigger "default" config CI on ROCm label Feb 23, 2024
@jithunnair-amd jithunnair-amd marked this pull request as ready for review February 23, 2024 23:31
@dnikolaev-amd
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases branch from 39ac71d to 0e68735 Compare February 26, 2024 15:36
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 27, 2024
@dnikolaev-amd
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases branch from 2380b9b to d59d1d3 Compare February 27, 2024 20:57
@dnikolaev-amd
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases branch from c664b9a to 4acb354 Compare February 28, 2024 16:01
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases branch from 1f0b8de to ad94b88 Compare March 5, 2024 18:48
@dnikolaev-amd
Copy link
Contributor Author

All tests passed. 19 tests enabled for ROCm #120504 (comment)

@jithunnair-amd jithunnair-amd requested a review from malfet March 6, 2024 16:57
@jithunnair-amd
Copy link
Collaborator

@malfet Please review and merge this PR, it's enabling some trivial cases for sparse unit tests for ROCm6.0 and above. CI passed: #120504 (comment)

@pruthvistony pruthvistony added the rocm This tag is for PRs from ROCm team label Mar 7, 2024
@jithunnair-amd jithunnair-amd requested a review from ezyang March 7, 2024 22:08
@dnikolaev-amd
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases branch from ad94b88 to 3c23f98 Compare March 8, 2024 12:43
@dnikolaev-amd
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the dnikolaev/enable_test_addmm_sizes_all_sparse_csr_for_complex128_on_rocm_for_trivial_cases branch from 3c23f98 to a89389d Compare March 11, 2024 13:25
@ezyang
Copy link
Contributor

ezyang commented Mar 12, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 12, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source rocm This tag is for PRs from ROCm team topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants