[pt2 export] small fix on non_persistent buffer unlift #120715
Conversation
zzh142857
requested review from
avikchaudhuri,
gmagogsfm,
tugsbayasgalan and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120715
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
|
This pull request was exported from Phabricator. Differential Revision: D54216772 |
zzh142857
force-pushed
the
export-D54216772
branch
from
553db83 to
b88715e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54216772 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D54216772 |
zzh142857
force-pushed
the
export-D54216772
branch
from
b88715e to
3372e56
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54216772 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D54216772 |
zzh142857
force-pushed
the
export-D54216772
branch
from
3372e56 to
6002910
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54216772 |
|
/easycla |
zzh142857
force-pushed
the
export-D54216772
branch
from
6002910 to
1e18a3c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54216772 |
zzh142857
force-pushed
the
export-D54216772
branch
from
1e18a3c to
c7debcc
Compare
Summary: Change to get_buffer from the input plain_graph_module instead of the new stateful_gm when restoring non_persistent buffers, since the stateful_gm doesn't contain the buffer yet. Test Plan: Added test case. `buck test caffe2/test:test_export -- test_unlift_nonpersistent_buffer` Reviewed By: suo, zhxchen17 Differential Revision: D54216772
zzh142857
force-pushed
the
export-D54216772
branch
from
c7debcc to
1b9eb17
Compare
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Summary: Change to get_buffer from the input plain_graph_module instead of the new stateful_gm when restoring non_persistent buffers, since the stateful_gm doesn't contain the buffer yet.
Test Plan:
Added test case.
buck test caffe2/test:test_export -- test_unlift_nonpersistent_bufferDifferential Revision: D54216772