Make translation validation more user friendly #120880
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120880
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Two main changes: - Don't rethrow the exception when we fail in TV, just throw the entire thing and trust the user will inspect logs / backtrace to see we failed in TV - Don't add an event to the TV logs until we've confirmed that the event actually runs without erroring. This prevents us from putting events that e.g., fail because the guard on data dependent size, and the failing in TV. Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: f260338 Pull Request resolved: #120880
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh and
miladm
ezyang
added
ciflow/trunk
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-12) Details for Dev Infra teamRaised by workflow job |
Two main changes: - Don't rethrow the exception when we fail in TV, just throw the entire thing and trust the user will inspect logs / backtrace to see we failed in TV - Don't add an event to the TV logs until we've confirmed that the event actually runs without erroring. This prevents us from putting events that e.g., fail because the guard on data dependent size, and the failing in TV. Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 1d88fcc Pull Request resolved: #120880
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-12) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 2 checks: trunk / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-12), inductor / rocm6.0-py3.8-inductor / test (inductor, 1, 1, linux.rocm.gpu.2) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Stack from ghstack (oldest at bottom):
Two main changes:
Don't rethrow the exception when we fail in TV, just throw the entire
thing and trust the user will inspect logs / backtrace to see we
failed in TV
Don't add an event to the TV logs until we've confirmed that the event
actually runs without erroring. This prevents us from putting events
that e.g., fail because the guard on data dependent size, and the
failing in TV.
Signed-off-by: Edward Z. Yang ezyang@meta.com