Skip to content

Conversation

whitelok
Copy link
Contributor

@whitelok whitelok commented Mar 2, 2024

cublasLt workspace warning info is misleading, the unit of measurement should be KiB instead of bytes

Fixes #ISSUE_NUMBER

Copy link

pytorch-bot bot commented Mar 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121073

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0a01acd with merge base 7f81563 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

linux-foundation-easycla bot commented Mar 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: whitelok / name: Karl Lok (Zhaokai Luo) (0a01acd)

@ezyang ezyang requested a review from eqy March 6, 2024 17:40
@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 6, 2024
@ezyang
Copy link
Contributor

ezyang commented Mar 6, 2024

needs cla

Copy link
Collaborator

@eqy eqy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

…t should be KiB instead of bytes.

fix CUBLASLT_WORKSPACE_SIZE default warning information to KiB.
@whitelok whitelok force-pushed the fixed-misleading-info-in-cublas-workspace-setting branch from 5ccd9c4 to 0a01acd Compare March 10, 2024 03:32
@whitelok
Copy link
Contributor Author

needs cla

Done

@ezyang ezyang added the topic: not user facing topic category label Mar 12, 2024
@ezyang
Copy link
Contributor

ezyang commented Mar 12, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 12, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ezyang
Copy link
Contributor

ezyang commented Mar 13, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@whitelok whitelok deleted the fixed-misleading-info-in-cublas-workspace-setting branch March 13, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants