Skip to content

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Mar 5, 2024

Summary

Updates the SDPA docs to fix some small inaccuracies and points to the new sdpa_kernel context manger. The Enum like type binded from cpp SDPBackend does not render its fields for some reason. Manually list them instead for now

cc @svekars @brycebortree

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121180

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit e346df7 with merge base 4f0481e (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@drisspg drisspg added module: docs Related to our documentation, both in docs/ and docblocks release notes: python_frontend python frontend release notes category topic: docs topic category labels Mar 5, 2024
@albanD albanD removed their request for review March 5, 2024 16:14
@drisspg
Copy link
Contributor Author

drisspg commented Mar 5, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 5, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: .github/workflows/trunk.yml / linux-focal-rocm6.0-py3.8 / test (default, 1, 1, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@drisspg
Copy link
Contributor Author

drisspg commented Mar 5, 2024

@pytorchbot merge -f "unrelated failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: docs Related to our documentation, both in docs/ and docblocks release notes: python_frontend python frontend release notes category topic: docs topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants