Skip to content

special-case cuda array interface of zero size #121458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

special-case cuda array interface of zero size #121458

wants to merge 1 commit into from

Conversation

@crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Mar 8, 2024

Fixes #98133
retry of #98134

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121458

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 92eb754 with merge base 6f74b76 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mikaylagawarecki mikaylagawarecki requested a review from ptrblck March 8, 2024 17:01
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 8, 2024
bdice
bdice approved these changes Mar 9, 2024
View reviewed changes
Copy link

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crcrpar Thanks for reviving this fix! This looks like what I would have expected to fix the bug.

@crcrpar crcrpar changed the title make zero-size cuda array interface a special case special-case cuda array interface of zero size Mar 9, 2024
@crcrpar
Copy link
Collaborator Author

crcrpar commented Mar 14, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased crpa/reopen-98134 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout crpa/reopen-98134 && git pull --rebase)

@crcrpar
Copy link
Collaborator Author

crcrpar commented Mar 14, 2024

@pytorchbot label ciflow/trunk

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 14, 2024
@crcrpar
Copy link
Collaborator Author

crcrpar commented Mar 17, 2024

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@crcrpar @pytorchmergebot
make zero-size cuda array interface a special case
92eb754 
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
@pytorchmergebot
Copy link
Collaborator

Successfully rebased crpa/reopen-98134 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout crpa/reopen-98134 && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@crcrpar
Copy link
Collaborator Author

crcrpar commented Mar 17, 2024

@mikaylagawarecki could you help me merge this pr?

mikaylagawarecki
mikaylagawarecki approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping to allow merging

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@mikaylagawarecki mikaylagawarecki added release notes: cuda release notes category topic: bug fixes topic category labels Mar 18, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@bdice
Copy link

bdice commented Mar 18, 2024

@crcrpar Thanks for reviving this fix, and thanks to all who helped!

@crcrpar crcrpar deleted the crpa/reopen-98134 branch March 18, 2024 16:46
@bdice bdice mentioned this pull request Dec 2, 2024
Merged
3 tasks
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Dec 2, 2024
@bdice
Update PyTorch to >=2.4.0 to get fix for CUDA array interface bug, an…
852338e 
…d drop CUDA 11 PyTorch tests. (#17475)

This PR updates our PyTorch lower bound to 2.4.0 to get the bugfix from pytorch/pytorch#121458.

Also, this PR drops CUDA 11 tests because conda-forge no longer produces CUDA 11 builds of PyTorch. This was causing a failure on Hopper GPUs because the last available CUDA 11 builds from conda-forge do not include sm90 support.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Matthew Roeschke (https://github.com/mroeschke)

URL: #17475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptrblck ptrblck ptrblck approved these changes

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

+1 more reviewer

@bdice bdice bdice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: cuda release notes category topic: bug fixes topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[interoperability] zero-size cuda arrays do not look supported

6 participants

@crcrpar @pytorchmergebot @mikaylagawarecki @bdice @ptrblck @pytorchbot