Skip to content

[AOTInductor] Reuse generated kernels between constant graph and main graph #121564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[AOTInductor] Reuse generated kernels between constant graph and main graph #121564

wants to merge 1 commit into from

Conversation

@muchulee8
Copy link
Contributor

@muchulee8 muchulee8 commented Mar 9, 2024 •
edited by pytorch-bot bot
Loading

Summary: We copy the src_to_kernel from constant graph to main graph so that we could avoid generating duplicating kernels. And pass throught the name counter such that no duplicated names will be generated.

Test Plan: Included in commit

Differential Revision: D54706767

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @aakhundov @ColinPeppler @amjames @desertfire @chauhang

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121564

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c37744d with merge base 0371743 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54706767

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54706767

muchulee8 added a commit to muchulee8/pytorch that referenced this pull request Mar 9, 2024
@muchulee8 @facebook-github-bot
[AOTInductor] Reuse generated kernels between constant graph and main…
b1ed1be 
… graph (pytorch#121564)

Summary:

We copy the src_to_kernel from constant graph to main graph so that we could avoid generating duplicating kernels. And pass throught the name counter such that no duplicated names will be generated.

Test Plan: Included in commit

Differential Revision: D54706767
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54706767

chenyang78
chenyang78 reviewed Mar 10, 2024
View reviewed changes
Copy link
Contributor

@chenyang78 chenyang78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint issue. Otherwise, LGTM. Thanks!

@muchulee8 @facebook-github-bot
[AOTInductor] Reuse generated kernels between constant graph and main…
c37744d 
… graph (pytorch#121564)

Summary:

We copy the src_to_kernel from constant graph to main graph so that we could avoid generating duplicating kernels. And pass throught the name counter such that no duplicated names will be generated.

Test Plan: Included in commit

Differential Revision: D54706767
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 11, 2024
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented Mar 12, 2024 •
edited
Loading

@muchulee8 The new test inductor/test_aot_inductor.py::AOTInductorTestABICompatibleCuda::test_duplicate_constant_folding_abi_compatible_cuda is failing on ROCm https://hud.pytorch.org/pytorch/pytorch/commit/767643301209fbe270dbe170886111917f836051. Could you help take a look? Adding ciflow/rocm on the PR will trigger the job

This was referenced Mar 12, 2024
Closed
Closed
@jeffdaily jeffdaily mentioned this pull request Mar 12, 2024
Closed
@huydhn huydhn mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyang78 chenyang78 chenyang78 approved these changes

@desertfire desertfire desertfire approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@muchulee8 @facebook-github-bot @pytorchmergebot @huydhn @chenyang78 @desertfire