Also test predispatch serialization #121652
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121652
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit faad2df with merge base 39ed038 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zhxchen17
approved these changes
Mar 11, 2024
[ghstack-poisoned]
angelayi
reviewed
Mar 11, 2024
Comment on lines
+339
to
+343
| if use_pre_dispatch: | ||
| _check_graph(pre_dispatch=True) | ||
| _check_graph(pre_dispatch=False) | ||
| else: | ||
| _check_graph(pre_dispatch=False) |
There was a problem hiding this comment.
Suggested change
| if use_pre_dispatch: | |
| _check_graph(pre_dispatch=True) | |
| _check_graph(pre_dispatch=False) | |
| else: | |
| _check_graph(pre_dispatch=False) | |
| if use_pre_dispatch: | |
| _check_graph(pre_dispatch=True) | |
| _check_graph(pre_dispatch=False) |
There was a problem hiding this comment.
We actually want to test both of them in use_pre_dispatch case. Meaning, we will always test aot-dispatch and pre-dispatch is just additional check
There was a problem hiding this comment.
yeah -- the _check_graph(pre_dispatch=False) is outside of the if statement :P
angelayi
approved these changes
Mar 11, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 12, 2024
In this PR, we create another dynamic test class for TestExport tests that basically serializes/deserializas pre-dispatch IR. I encountered 4 additional failures. But 3 of them are due to different operator showing up in the graph and only one legit failure which is tracked by another task internally. Pull Request resolved: #121678 Approved by: https://github.com/angelayi ghstack dependencies: #121652
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 12, 2024
Pull Request resolved: #121687 Approved by: https://github.com/avikchaudhuri ghstack dependencies: #121652, #121678
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 12, 2024
) Pull Request resolved: #121710 Approved by: https://github.com/BoyuanFeng ghstack dependencies: #121652, #121678, #121687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):