Add scuba logging for TorchScript usage #121936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

gmagogsfm wants to merge 1 commit into pytorch:main from gmagogsfm:export-D54923510

Contributor

gmagogsfm commented Mar 14, 2024

Summary: Infra to log live usage of TorchScript internally

Test Plan: manually tested

Differential Revision: D54923510

pytorch-bot bot commented Mar 14, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121936

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

[Mitigated] CI is broken due to lack of public access to number of buckets

✅ You can merge normally! (1 Unrelated Failure)

As of commit b19f0e5 with merge base a17cd22 ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

trunk / macos-12-py3-arm64-mps / test (mps, 1, 1, macos-m1-stable) (gh)
test_mps.py::TestConsistencyCPU::test_output_grad_match_clamp_cpu_float16

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added the release notes: jit label

Contributor

facebook-github-bot commented Mar 14, 2024

This pull request was exported from Phabricator. Differential Revision: D54923510

facebook-github-bot added the fb-exported label

gmagogsfm force-pushed the export-D54923510 branch from c6e7f70 to f3e25ed Compare

March 14, 2024 22:48

Contributor

facebook-github-bot commented Mar 14, 2024

This pull request was exported from Phabricator. Differential Revision: D54923510

Contributor Author

gmagogsfm commented Mar 14, 2024

@pytorchbot label "topic: not user facing"

gmagogsfm requested a review from zhxchen17

March 14, 2024 22:49

pytorch-bot bot added the topic: not user facing label

gmagogsfm force-pushed the export-D54923510 branch from f3e25ed to 36046e6 Compare

March 15, 2024 17:36

Contributor

facebook-github-bot commented Mar 15, 2024

This pull request was exported from Phabricator. Differential Revision: D54923510

gmagogsfm force-pushed the export-D54923510 branch from 36046e6 to 6989414 Compare

March 15, 2024 17:45

Contributor

facebook-github-bot commented Mar 15, 2024

This pull request was exported from Phabricator. Differential Revision: D54923510

zhxchen17 approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

gmagogsfm force-pushed the export-D54923510 branch from 6989414 to 1ef9993 Compare

March 15, 2024 22:08

Contributor

facebook-github-bot commented Mar 15, 2024

This pull request was exported from Phabricator. Differential Revision: D54923510

gmagogsfm added a commit to gmagogsfm/pytorch-1 that referenced this pull request


          Add scuba logging for TorchScript usage (pytorch#121936)

61f4efe

Summary:

Infra to log live usage of TorchScript internally

Test Plan: manually tested

Reviewed By: zhxchen17

Differential Revision: D54923510

gmagogsfm force-pushed the export-D54923510 branch from 1ef9993 to 61f4efe Compare

March 15, 2024 22:13

Contributor

facebook-github-bot commented Mar 15, 2024

This pull request was exported from Phabricator. Differential Revision: D54923510

gmagogsfm force-pushed the export-D54923510 branch from 61f4efe to 65c4408 Compare

March 18, 2024 20:50

Contributor

facebook-github-bot commented Mar 18, 2024

This pull request was exported from Phabricator. Differential Revision: D54923510


          Add scuba logging for TorchScript usage (pytorch#121936)

b19f0e5

Summary:
Pull Request resolved: pytorch#121936

Infra to log live usage of TorchScript internally

bypass-github-export-checks

Test Plan: manually tested

Reviewed By: zhxchen17

Differential Revision: D54923510

Contributor

facebook-github-bot commented Mar 18, 2024

This pull request was exported from Phabricator. Differential Revision: D54923510

gmagogsfm force-pushed the export-D54923510 branch from 65c4408 to b19f0e5 Compare

March 18, 2024 20:56

Contributor

facebook-github-bot commented Mar 19, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

Collaborator

pytorchmergebot commented Mar 19, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the merging label

pytorchmergebot closed this in

ba9a1d9

pytorchmergebot added Merged and removed merging labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged release notes: jit topic: not user facing