release gil in prepareProfiler

[ngimel]

Initializing profiler while holding gil can lead to deadlocks, as it makes some presumably synchronizing cuda calls

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121949

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 9c0b405 with merge base efbeefb ():

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

• trunk / macos-12-py3-arm64 / test (default, 1, 3, macos-m1-stable, unstable) (gh)
  test_tensorboard.py::TestTensorBoardSummary::test_hparams_string

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ngimel]

cc @aaronenyeshi. Even if some cupti calls that kineto makes are not thread safe, they should be guarded by a lock in kineto, not by gil.

[aaronenyeshi]

Thanks for this diff, I will import it to see if any internal CI depends on the gil.

[facebook-github-bot]

@aaronenyeshi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here