-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Increase numel limit to 2^63 for replicatepad1d #122199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122199
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (10 Unrelated Failures)As of commit f03bfaa with merge base 88ebdbc ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D55030372 |
/easycla |
/easycla |
Summary: As title Test Plan: ``` CUDA_VISIBLE_DEVICES=5 buck2 test mode/opt //caffe2/test:test_nn_cuda -- test_replicatepad_64bit_indexing ``` Also benchmarked in N5106027 ``` device_ms, cpu_ms, gb/device_ms*1000 # before changes 11.058772478103638 18.912256770000006 735.4118906278957 # after changes 10.621162576675415 18.58972748 765.7121070725207 ``` Differential Revision: D55030372
1522f25
to
f03bfaa
Compare
This pull request was exported from Phabricator. Differential Revision: D55030372 |
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: As title Test Plan: ``` CUDA_VISIBLE_DEVICES=5 buck2 test mode/opt //caffe2/test:test_nn_cuda -- test_replicatepad_64bit_indexing ``` Also benchmarked in N5106027 ``` device_ms, cpu_ms, gb/device_ms*1000 # before changes 11.058772478103638 18.912256770000006 735.4118906278957 # after changes 10.621162576675415 18.58972748 765.7121070725207 ``` Differential Revision: D55030372 Pull Request resolved: #122199 Approved by: https://github.com/ezyang
Summary: As title
Test Plan:
Also benchmarked in N5106027
Differential Revision: D55030372