Use zeros for NJT dummy to avoid messing with randomness #122902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122902
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bc9f2a4 with merge base 1e8d4b3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
zou3519
reviewed
Mar 28, 2024
Comment on lines
+423
to
+424
| values=torch.zeros(3, 3, device="meta"), | ||
| offsets=torch.zeros(3, device="meta", dtype=torch.int64), |
There was a problem hiding this comment.
Is it possible to add a test case for what vincent was running into?
There was a problem hiding this comment.
I tried but wasn't able to repro it after #122704 landed. I decided to make the change here anyway to avoid any other unforeseen randomness-related problems
zou3519
approved these changes
Mar 28, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 28, 2024
This broke [internal tests](https://www.internalfb.com/intern/test/844425064039866/) that run with unset `NDEBUG`. It wasn't initially caught because we don't test with unset `NDEBUG` in OSS CI. Pull Request resolved: #122917 Approved by: https://github.com/soulitzer ghstack dependencies: #122902
sanketpurandare
pushed a commit
to sanketpurandare/pytorch
that referenced
this pull request
Apr 22, 2024
) Use of randomness was breaking vmap. Pull Request resolved: pytorch#122902 Approved by: https://github.com/vmoens, https://github.com/zou3519
sanketpurandare
pushed a commit
to sanketpurandare/pytorch
that referenced
this pull request
Apr 22, 2024
This broke [internal tests](https://www.internalfb.com/intern/test/844425064039866/) that run with unset `NDEBUG`. It wasn't initially caught because we don't test with unset `NDEBUG` in OSS CI. Pull Request resolved: pytorch#122917 Approved by: https://github.com/soulitzer ghstack dependencies: pytorch#122902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Use of randomness was breaking vmap.