Skip to content

realize inputs to mem bound mm decomposition #123165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

realize inputs to mem bound mm decomposition #123165

wants to merge 3 commits into from

Conversation

eellison
Copy link
Contributor

@eellison eellison commented Apr 2, 2024 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123165

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9e4f613 with merge base 8ce29f1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

eellison added a commit that referenced this pull request Apr 2, 2024
@eellison
realize inputs to mem bound mm decomposition
eb90880 
ghstack-source-id: e3b8a86
Pull Request resolved: #123165
@eellison
Copy link
Contributor Author

eellison commented Apr 2, 2024

@eellison has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@eellison eellison closed this Apr 3, 2024
@eellison eellison reopened this Apr 12, 2024
@eellison
Update on "realize inputs to mem bound mm decomposition"
c8f52ee 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang

Differential Revision: [D55639709](https://our.internmc.facebook.com/intern/diff/D55639709)

[ghstack-poisoned]
eellison added a commit that referenced this pull request Apr 14, 2024
@eellison
realize inputs to mem bound mm decomposition
831444b 
ghstack-source-id: 7336846
Pull Request resolved: #123165
@eellison eellison requested a review from jackiexu1992 April 15, 2024 21:07
@eellison
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@eellison
Update
9e4f613 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/eellison/626/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/123165)

pytorchmergebot pushed a commit that referenced this pull request Apr 15, 2024
@eellison
realize inputs to mem bound mm decomposition
8413335 
ghstack-source-id: d182fdb
Pull Request resolved: #123165
jackiexu1992
jackiexu1992 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@jackiexu1992 jackiexu1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 16, 2024
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@eellison eellison added the topic: not user facing topic category label Apr 18, 2024
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
@eellison
realize inputs to mem bound mm decomposition (#123165)
4ba1a76 
Differential Revision: [D55639709](https://our.internmc.facebook.com/intern/diff/D55639709)
Pull Request resolved: #123165
Approved by: https://github.com/jackiexu1992
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
@eellison
realize inputs to mem bound mm decomposition (pytorch#123165)
f45c32f 
Differential Revision: [D55639709](https://our.internmc.facebook.com/intern/diff/D55639709)
Pull Request resolved: pytorch#123165
Approved by: https://github.com/jackiexu1992
@github-actions github-actions bot deleted the gh/eellison/626/head branch May 31, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackiexu1992 jackiexu1992 jackiexu1992 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eellison @pytorchmergebot @jackiexu1992