Skip to content

Fix conv decomp when running to core-aten #123283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix conv decomp when running to core-aten #123283

wants to merge 2 commits into from

Conversation

tugsbayasgalan
Copy link
Contributor

@tugsbayasgalan tugsbayasgalan commented Apr 3, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Differential Revision: D55709374

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123283

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 2201a95 with merge base 691054e (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

tugsbayasgalan added a commit that referenced this pull request Apr 3, 2024
@tugsbayasgalan
Fix conv decomp when running to core-aten
9366ea5 
ghstack-source-id: 623dca8
Pull Request resolved: #123283
@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 3, 2024
@tugsbayasgalan
Copy link
Contributor Author

@pytorchbot merge -f "Landed internally"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced Apr 4, 2024
Closed
Closed
sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request Apr 22, 2024
@tugsbayasgalan
Fix conv decomp when running to core-aten (pytorch#123283)
c90cad9 
Differential Revision: [D55709374](https://our.internmc.facebook.com/intern/diff/D55709374)
Pull Request resolved: pytorch#123283
Approved by: https://github.com/angelayi
@github-actions github-actions bot deleted the gh/tugsbayasgalan/200/head branch May 4, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelayi angelayi angelayi approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tugsbayasgalan @pytorchmergebot @angelayi