Skip to content

Reduce guards of optimizer state dict to guard once per param group #123413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Reduce guards of optimizer state dict to guard once per param group #123413

wants to merge 3 commits into from

Conversation

mlazos
Copy link
Contributor

@mlazos mlazos commented Apr 5, 2024 •
edited by pytorch-bot bot
Loading

@mlazos
First impl
a2e2513 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123413

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Unrelated Failures

As of commit 13582c8 with merge base de14717 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mlazos mlazos changed the title First impl Reduce guards of optimizer state dict to guard once per param group Apr 5, 2024
@mlazos mlazos requested a review from anijain2305 April 5, 2024 01:08
@mlazos mlazos added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 5, 2024
anijain2305
anijain2305 reviewed Apr 5, 2024
View reviewed changes
@mlazos
Update on "Reduce guards of optimizer state dict to guard once per pa…
e90bae9 
…ram group"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang

[ghstack-poisoned]
mlazos added a commit that referenced this pull request Apr 5, 2024
@mlazos
First impl
e780463 
ghstack-source-id: d69a2bd
Pull Request resolved: #123413
@mlazos
Update on "Reduce guards of optimizer state dict to guard once per pa…
13582c8 
…ram group"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang

[ghstack-poisoned]
mlazos added a commit that referenced this pull request Apr 5, 2024
@mlazos
First impl
2626ae5 
ghstack-source-id: d7b5dfc
Pull Request resolved: #123413
@mlazos
Copy link
Contributor Author

mlazos commented Apr 5, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@mlazos
Copy link
Contributor Author

mlazos commented Apr 5, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mlazos
Copy link
Contributor Author

mlazos commented Apr 6, 2024

@pytorchbot merge -f "unrelated failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request Apr 22, 2024
@mlazos
Reduce guards of optimizer state dict to guard once per param group (p…
094110d 
…ytorch#123413)

Pull Request resolved: pytorch#123413
Approved by: https://github.com/anijain2305
@github-actions github-actions bot deleted the gh/mlazos/14/head branch May 6, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anijain2305 anijain2305 anijain2305 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor release notes: dynamo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mlazos @pytorchmergebot @anijain2305