Skip to content

Enable UFMT on test/cpp_api_parity, test/cpp_extensions, test/create_dummy_torchscript_model.py, test/custom_backend, test/custom_operator #123518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Enable UFMT on test/cpp_api_parity, test/cpp_extensions, test/create_dummy_torchscript_model.py, test/custom_backend, test/custom_operator #123518

wants to merge 5 commits into from

Conversation

shink
Copy link
Contributor

@shink shink commented Apr 7, 2024 •
edited
Loading

Partially addresses #123062

Ran lintrunner on:

  • test/cpp_api_parity
  • test/cpp_extensions
  • test/create_dummy_torchscript_model.py
  • test/custom_backend
  • test/custom_operator

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123518

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a9d4cb3 with merge base e3ea316 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 7, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 7, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@shink
Copy link
Contributor Author

shink commented Apr 7, 2024

@pytorchbot rebase

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 7, 2024

You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra.

@shink
Copy link
Contributor Author

shink commented Apr 7, 2024

@huydhn please take a look, thank you very much.

@shink shink changed the title UFMT formatting on test/cpp_api_parity UFMT formatting on test/cpp_api_parity, test/cpp_extensions Apr 7, 2024
@shink shink changed the title UFMT formatting on test/cpp_api_parity, test/cpp_extensions UFMT formatting on test/cpp_api_parity, test/cpp_extensions, test/create_dummy_torchscript_model.py, test/custom_backend Apr 7, 2024
@shink shink changed the title UFMT formatting on test/cpp_api_parity, test/cpp_extensions, test/create_dummy_torchscript_model.py, test/custom_backend Enable UFMT on test/cpp_api_parity, test/cpp_extensions, test/create_dummy_torchscript_model.py, test/custom_backend Apr 7, 2024
@shink
Copy link
Contributor Author

shink commented Apr 7, 2024

@pytorchbot drci

@shink shink changed the title Enable UFMT on test/cpp_api_parity, test/cpp_extensions, test/create_dummy_torchscript_model.py, test/custom_backend Enable UFMT on test/cpp_api_parity, test/cpp_extensions, test/create_dummy_torchscript_model.py, test/custom_backend, test/custom_operator Apr 8, 2024
@huydhn
Copy link
Contributor

huydhn commented Apr 8, 2024

@pytorchbot merge -f 'Lint fixes, no need to run trunk jobs'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request Apr 22, 2024
@shink
Enable UFMT on test/cpp_api_parity, test/cpp_extensions, `test/cr…
4dd4df9 
…eate_dummy_torchscript_model.py`, `test/custom_backend`, `test/custom_operator` (pytorch#123518)

Partially addresses pytorch#123062

Ran lintrunner on:

- `test/cpp_api_parity`
- `test/cpp_extensions`
- `test/create_dummy_torchscript_model.py`
- `test/custom_backend`
- `test/custom_operator`

Pull Request resolved: pytorch#123518
Approved by: https://github.com/huydhn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

Merged open source test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shink @huydhn @pytorchmergebot @pytorchbot