Skip to content

Fix _LazyConvXdMixin.initialize_parameters and add related tests #123756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Fix _LazyConvXdMixin.initialize_parameters and add related tests #123756

wants to merge 4 commits into from

Conversation

sanjeevg15
Copy link
Contributor

Fixes #123257

_LazyConvXdMixin.initialize_parameters did not handle positional args (other than input) and kwargs to be passed on to the corresponding non-lazy class' .forward() method.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123756

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 100d09f with merge base 3dde6a4 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 10, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@sanjeevg15 sanjeevg15 changed the title Fix _LazyConvXdMixin.initialize_parameters and add related tests #123257 Fix _LazyConvXdMixin.initialize_parameters and add related tests Apr 10, 2024
mikaylagawarecki
mikaylagawarecki approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge if CI is green

@albanD albanD removed their request for review April 11, 2024 19:54
@mikaylagawarecki
Copy link
Contributor

Hm, the failures seem related

@sanjeevg15
Copy link
Contributor Author

Yeah, will take a look soon

@sanjeevg15
Copy link
Contributor Author

The new tests I added are failing with PYTORCH_TEST_WITH_DYNAMO=1. However, other similar tests seem to be skipped with PYTORCH_TEST_WITH_DYNAMO=1. So, I'm wondering if the new tests should also be skipped. That should resolve the CI failures.

New tests added:

  1. test_lazy_conv_transpose1d_kwargs
  2. test_lazy_conv_transpose2d_kwargs
  3. test_lazy_conv_transpose3d_kwargs

Other similar tests that were skipped:

  1. test_lazy_conv_transpose1d
  2. test_lazy_conv_transpose2d
  3. test_lazy_conv_transpose3d

Result of PYTORCH_TEST_WITH_DYNAMO=1 pytest test/nn/test_lazy_modules.py -k "test_lazy_conv_transpose and not pickle and not state":

image

@mikaylagawarecki
Copy link
Contributor

That sounds reasonable to me, thank you for looking into it

@mikaylagawarecki
Copy link
Contributor

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@sanjeevg15 @pytorchmergebot
Fix _LazyConvXdMixin.initialize_parameters and add related tests (pyt…
9dffe6d 
…orch#123257)

Handle args and Fix _LazyConvXdMixin.initialize_parameters did not handle positional args (other than input) and kwargs to be passed on to the corresponding non-lazy class' .forward() method.
@sanjeevg15 @pytorchmergebot
Fix linting
587bf5e
@sanjeevg15 @pytorchmergebot
Add test_lazy_conv_transposexd_kwargs tests to dynamo_expected_failures
762a0e6
@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix-lazy-conv-mixin onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix-lazy-conv-mixin && git pull --rebase)

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 13, 2024
@mikaylagawarecki mikaylagawarecki added release notes: nn release notes category topic: bug fixes topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 13, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request Apr 22, 2024
@sanjeevg15
Fix _LazyConvXdMixin.initialize_parameters and add related tests (py…
821ac4b 
…torch#123756)

Fixes pytorch#123257

_LazyConvXdMixin.initialize_parameters did not handle positional args (other than input) and kwargs to be passed on to the corresponding non-lazy class' .forward() method.
Pull Request resolved: pytorch#123756
Approved by: https://github.com/mikaylagawarecki
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
@sanjeevg15
Fix _LazyConvXdMixin.initialize_parameters and add related tests (py…
0e62aab 
…torch#123756)

Fixes pytorch#123257

_LazyConvXdMixin.initialize_parameters did not handle positional args (other than input) and kwargs to be passed on to the corresponding non-lazy class' .forward() method.
Pull Request resolved: pytorch#123756
Approved by: https://github.com/mikaylagawarecki
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nn release notes category topic: bug fixes topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setting output_size argument during forward breaks LazyConvTranspose

4 participants

@sanjeevg15 @mikaylagawarecki @pytorchmergebot @pytorchbot