-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Inductor] Fix endless recursion in codecache.DLLWrapper.__getattr__ #123931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123931
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ee86a62 with merge base failed to retrieve merge base, please contact dev infra: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lib_path: str, | ||
): | ||
self.lib_path = lib_path | ||
self.is_open = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't put that here, and the subsequent call to cdll.LoadLibrary fails for any reason, an endless recursion results..
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: PR #123930 has not been reviewed yet |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ytorch#123931) Pull Request resolved: pytorch#123931 Approved by: https://github.com/peterbell10
…ytorch#123931) Pull Request resolved: pytorch#123931 Approved by: https://github.com/peterbell10
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @muchulee8 @aakhundov @ColinPeppler @amjames @desertfire @chauhang