Capture triton kernel in execution trace #124140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

shengfukevin wants to merge 1 commit into pytorch:main from shengfukevin:export-D56162599

Contributor

shengfukevin commented Apr 16, 2024 •

edited by pytorch-bot bot

Loading

Summary: This DIFF is to capture triton kernels in execution trace.

Test Plan: buck test mode/dev-nosan caffe2/test:profiler -- test_execution_trace_with_pt2

Differential Revision: D56162599

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames @desertfire @chauhang

shengfukevin requested a review from aaronenyeshi as a code owner

April 16, 2024 03:08

pytorch-bot bot commented Apr 16, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124140

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 1adc115 with merge base 67bd43b ():

NEW FAILURE - The following job has failed:

trunk / linux-focal-cuda12.1-py3.10-gcc9 / test (nogpu_AVX512, 1, 1, linux.2xlarge) (gh)
profiler/test_profiler.py::TestProfiler::test_source_multithreaded_basic_work_in_main_thread_True

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / linux-focal-py3.11-clang10 / test (default, 2, 3, linux.2xlarge) (gh)
profiler/test_profiler.py::TestProfiler::test_source_multithreaded_basic_work_in_main_thread_True

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor module: inductor labels

Contributor

facebook-github-bot commented Apr 16, 2024

This pull request was exported from Phabricator. Differential Revision: D56162599

facebook-github-bot added the fb-exported label

shengfukevin force-pushed the export-D56162599 branch from 26f97c7 to 2cea6d4 Compare

April 16, 2024 03:10

shengfukevin added a commit to shengfukevin/pytorch that referenced this pull request


          Capture triton kernel in execution trace (pytorch#124140)

2cea6d4

Summary:

This DIFF is to capture triton kernels in execution trace.

Test Plan: buck test  mode/dev-nosan caffe2/test:profiler -- test_execution_trace_with_pt2

Differential Revision: D56162599

Contributor

facebook-github-bot commented Apr 16, 2024

This pull request was exported from Phabricator. Differential Revision: D56162599

shengfukevin force-pushed the export-D56162599 branch from 2cea6d4 to 54aa267 Compare

April 16, 2024 17:51

Contributor

facebook-github-bot commented Apr 16, 2024

This pull request was exported from Phabricator. Differential Revision: D56162599

shengfukevin force-pushed the export-D56162599 branch from 54aa267 to 23eb924 Compare

April 16, 2024 17:52

Contributor

facebook-github-bot commented Apr 16, 2024

This pull request was exported from Phabricator. Differential Revision: D56162599

shengfukevin force-pushed the export-D56162599 branch from 23eb924 to 67b0b55 Compare

April 16, 2024 18:03

Contributor

facebook-github-bot commented Apr 16, 2024

This pull request was exported from Phabricator. Differential Revision: D56162599

shengfukevin force-pushed the export-D56162599 branch from 67b0b55 to ab4c3c5 Compare

April 16, 2024 18:03

Contributor

facebook-github-bot commented Apr 16, 2024

This pull request was exported from Phabricator. Differential Revision: D56162599

shengfukevin requested a review from briancoutinho

April 16, 2024 18:04

shengfukevin force-pushed the export-D56162599 branch from ab4c3c5 to 405e9b4 Compare

April 16, 2024 18:42

Contributor

facebook-github-bot commented Apr 16, 2024

This pull request was exported from Phabricator. Differential Revision: D56162599


          Capture triton kernel in execution trace (pytorch#124140)

1adc115

Summary:

This DIFF is to capture triton kernels in execution trace.

Test Plan: buck test  mode/dev-nosan caffe2/test:profiler -- test_execution_trace_with_pt2

Differential Revision: D56162599

shengfukevin force-pushed the export-D56162599 branch from 405e9b4 to 1adc115 Compare

April 16, 2024 18:43

Contributor

facebook-github-bot commented Apr 16, 2024

This pull request was exported from Phabricator. Differential Revision: D56162599

briancoutinho approved these changes

View reviewed changes

Contributor

briancoutinho left a comment

lgtm!

pytorch-bot bot added the ciflow/trunk label

aaronenyeshi requested a review from davidberard98

April 18, 2024 17:54

Contributor

facebook-github-bot commented Apr 18, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Apr 18, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot closed this in

89407ec

pytorchmergebot added Merged and removed merging labels

Contributor

facebook-github-bot commented Apr 19, 2024

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

Collaborator

pytorchmergebot commented Apr 19, 2024

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request


          Revert "Capture triton kernel in execution trace (#124140)"

f87c788

This reverts commit 89407ec.

Reverted #124140 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#124140 (comment)))

Collaborator

pytorchmergebot commented Apr 19, 2024

@shengfukevin your PR has been successfully reverted.

pytorchmergebot added the Reverted label

pytorchmergebot reopened this

sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request


          Capture triton kernel in execution trace (pytorch#124140)

758f326

Summary: This DIFF is to capture triton kernels in execution trace.

Test Plan: buck test  mode/dev-nosan caffe2/test:profiler -- test_execution_trace_with_pt2

Differential Revision: D56162599

Pull Request resolved: pytorch#124140
Approved by: https://github.com/briancoutinho

sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request


          Revert "Capture triton kernel in execution trace (pytorch#124140)"

423cb4a

This reverts commit 89407ec.

Reverted pytorch#124140 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#124140 (comment)))

shengfukevin closed this

petrex pushed a commit to petrex/pytorch that referenced this pull request


          Capture triton kernel in execution trace (pytorch#124140)

9c5fdde

Summary: This DIFF is to capture triton kernels in execution trace.

Test Plan: buck test  mode/dev-nosan caffe2/test:profiler -- test_execution_trace_with_pt2

Differential Revision: D56162599

Pull Request resolved: pytorch#124140
Approved by: https://github.com/briancoutinho

petrex pushed a commit to petrex/pytorch that referenced this pull request


          Revert "Capture triton kernel in execution trace (pytorch#124140)"

6d72403

This reverts commit 89407ec.

Reverted pytorch#124140 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#124140 (comment)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk fb-exported Merged module: inductor Reverted