Change register_autograd to reflect ordering of setup_context and backward #124403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kward old: `register_autograd(setup_context, backward, /)` new: `register_autograd(backward, /, *, setup_context=None)` Motivations: - We introduce these APIs as "give us a backward and use setup_context to save things for backward". - setup_context isn't always necessary. Test Plan: - tests [ghstack-poisoned]
This was referenced Apr 18, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124403
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 86d679b with merge base 4a0900d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 18, 2024
albanD
added
the
suppress-bc-linter
albanD
approved these changes
Apr 18, 2024
zou3519
added
release notes: composability
…ext and backward" old: `register_autograd(setup_context, backward, /)` new: `register_autograd(backward, /, *, setup_context=None)` Motivations: - We introduce these APIs as "give us a backward and use setup_context to save things for backward". - setup_context isn't always necessary. Test Plan: - tests [ghstack-poisoned]
This was referenced Apr 18, 2024
…ext and backward" old: `register_autograd(setup_context, backward, /)` new: `register_autograd(backward, /, *, setup_context=None)` Motivations: - We introduce these APIs as "give us a backward and use setup_context to save things for backward". - setup_context isn't always necessary. Test Plan: - tests [ghstack-poisoned]
…ext and backward" old: `register_autograd(setup_context, backward, /)` new: `register_autograd(backward, /, *, setup_context=None)` Motivations: - We introduce these APIs as "give us a backward and use setup_context to save things for backward". - setup_context isn't always necessary. Test Plan: - tests [ghstack-poisoned]
This was referenced Apr 19, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 19, 2024
- the op is automatically "pt2-compliant" - In general we want to turn on needs_fixed_stride_order for all customm ops, but this needs some more work, so we're just going to turn it on for the new custom op API. Test Plan: - existing tests Pull Request resolved: #124414 Approved by: https://github.com/albanD ghstack dependencies: #124180, #124200, #124299, #124134, #124199, #124403
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 19, 2024
Motivations: - this is pretty redundant with test_aot_dispatch_dynamic. - The user story for opcheck is that a user should use opcheck to see if their operator was "registered correctly". If a user's custom op only supports dynamic shapes, then it's a bit awkward for one of the tests (e.g. `test_aot_dispatch_static`) to fail. - We've already stopped running test_aot_dispatch_static in all of our opcheck tests. Test Plan: - wait for CI Pull Request resolved: #124495 Approved by: https://github.com/williamwen42 ghstack dependencies: #124180, #124200, #124299, #124134, #124199, #124403, #124414
pytorch-bot bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
…kward (#124403) old: `register_autograd(setup_context, backward, /)` new: `register_autograd(backward, /, *, setup_context=None)` Motivations: - We introduce these APIs as "give us a backward and use setup_context to save things for backward". - setup_context isn't always necessary. Test Plan: - tests Pull Request resolved: #124403 Approved by: https://github.com/albanD ghstack dependencies: #124180, #124200, #124299, #124134, #124199
pytorch-bot bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
- the op is automatically "pt2-compliant" - In general we want to turn on needs_fixed_stride_order for all customm ops, but this needs some more work, so we're just going to turn it on for the new custom op API. Test Plan: - existing tests Pull Request resolved: #124414 Approved by: https://github.com/albanD ghstack dependencies: #124180, #124200, #124299, #124134, #124199, #124403
pytorch-bot bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
Motivations: - this is pretty redundant with test_aot_dispatch_dynamic. - The user story for opcheck is that a user should use opcheck to see if their operator was "registered correctly". If a user's custom op only supports dynamic shapes, then it's a bit awkward for one of the tests (e.g. `test_aot_dispatch_static`) to fail. - We've already stopped running test_aot_dispatch_static in all of our opcheck tests. Test Plan: - wait for CI Pull Request resolved: #124495 Approved by: https://github.com/williamwen42 ghstack dependencies: #124180, #124200, #124299, #124134, #124199, #124403, #124414
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
…kward (#124403) old: `register_autograd(setup_context, backward, /)` new: `register_autograd(backward, /, *, setup_context=None)` Motivations: - We introduce these APIs as "give us a backward and use setup_context to save things for backward". - setup_context isn't always necessary. Test Plan: - tests Pull Request resolved: #124403 Approved by: https://github.com/albanD ghstack dependencies: #124180, #124200, #124299, #124134, #124199
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
- the op is automatically "pt2-compliant" - In general we want to turn on needs_fixed_stride_order for all customm ops, but this needs some more work, so we're just going to turn it on for the new custom op API. Test Plan: - existing tests Pull Request resolved: #124414 Approved by: https://github.com/albanD ghstack dependencies: #124180, #124200, #124299, #124134, #124199, #124403
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
May 3, 2024
) Motivations: - this is pretty redundant with test_aot_dispatch_dynamic. - The user story for opcheck is that a user should use opcheck to see if their operator was "registered correctly". If a user's custom op only supports dynamic shapes, then it's a bit awkward for one of the tests (e.g. `test_aot_dispatch_static`) to fail. - We've already stopped running test_aot_dispatch_static in all of our opcheck tests. Test Plan: - wait for CI Pull Request resolved: pytorch#124495 Approved by: https://github.com/williamwen42 ghstack dependencies: pytorch#124180, pytorch#124200, pytorch#124299, pytorch#124134, pytorch#124199, pytorch#124403, pytorch#124414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
old:
register_autograd(setup_context, backward, /)new:
register_autograd(backward, /, *, setup_context=None)Motivations:
to save things for backward".
Test Plan: