[DDP][PT2D] Fix some tracing bugs of DDP #124421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. We need to clear the cache of get_legacy_mod_inlinelist to ensure the newly added rule will be captured. 2. Don't add the hook if the parameter does not require gradient. Differential Revision: [D56315534](https://our.internmc.facebook.com/intern/diff/D56315534/) [ghstack-poisoned]
fegin
requested review from
albanD,
jbschlosser and
mikaylagawarecki
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124421
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit cb018ed with merge base c5fafe9 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
oncall: distributed
|
This pull request was exported from Phabricator. Differential Revision: D56315534 |
This was referenced Apr 18, 2024
fegin
requested review from
wconstab and
yf225
and removed request for
albanD,
jbschlosser and
mikaylagawarecki
yf225
approved these changes
Apr 18, 2024
1. We need to clear the cache of get_legacy_mod_inlinelist to ensure the newly added rule will be captured. 2. Don't add the hook if the parameter does not require gradient. Differential Revision: [D56315534](https://our.internmc.facebook.com/intern/diff/D56315534/) cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D56315534 |
fegin
added
the
ciflow/periodic
1. We need to clear the cache of get_legacy_mod_inlinelist to ensure the newly added rule will be captured. 2. Don't add the hook if the parameter does not require gradient. Differential Revision: [D56315534](https://our.internmc.facebook.com/intern/diff/D56315534/) cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D56315534 |
1. We need to clear the cache of get_legacy_mod_inlinelist to ensure the newly added rule will be captured. 2. Don't add the hook if the parameter does not require gradient. Differential Revision: [D56315534](https://our.internmc.facebook.com/intern/diff/D56315534/) cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D56315534 |
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 23, 2024
…124422) As title Differential Revision: [D56315533](https://our.internmc.facebook.com/intern/diff/D56315533/) Pull Request resolved: #124422 Approved by: https://github.com/yf225 ghstack dependencies: #124421
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 24, 2024
) In order to make replicate work with Meta tensor, we need to do lazy Initialization for the replicate API. This PR impelements the lazy initialization and ensures that replicate still work with the new DDP compilation. Differential Revision: [D55787340](https://our.internmc.facebook.com/intern/diff/D55787340/) Pull Request resolved: #123424 Approved by: https://github.com/yf225 ghstack dependencies: #124421, #124422
This was referenced Apr 24, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 25, 2024
As title Differential Revision: [D56508696](https://our.internmc.facebook.com/intern/diff/D56508696/) Pull Request resolved: #124829 Approved by: https://github.com/yf225 ghstack dependencies: #124421, #124422, #123424
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 25, 2024
As title Differential Revision: [D56521582](https://our.internmc.facebook.com/intern/diff/D56521582/) Pull Request resolved: #124846 Approved by: https://github.com/LucasLLC, https://github.com/wz337 ghstack dependencies: #124421, #124422, #123424
alat-rights
pushed a commit
to alat-rights/pytorch
that referenced
this pull request
Apr 26, 2024
As title Differential Revision: [D56508696](https://our.internmc.facebook.com/intern/diff/D56508696/) Pull Request resolved: pytorch#124829 Approved by: https://github.com/yf225 ghstack dependencies: pytorch#124421, pytorch#124422, pytorch#123424
alat-rights
pushed a commit
to alat-rights/pytorch
that referenced
this pull request
Apr 26, 2024
As title Differential Revision: [D56521582](https://our.internmc.facebook.com/intern/diff/D56521582/) Pull Request resolved: pytorch#124846 Approved by: https://github.com/LucasLLC, https://github.com/wz337 ghstack dependencies: pytorch#124421, pytorch#124422, pytorch#123424
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
1. We need to clear the cache of get_legacy_mod_inlinelist to ensure the newly added rule will be captured. 2. Don't add the hook if the parameter does not require gradient. Differential Revision: [D56315534](https://our.internmc.facebook.com/intern/diff/D56315534/) Pull Request resolved: #124421 Approved by: https://github.com/yf225
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
…124422) As title Differential Revision: [D56315533](https://our.internmc.facebook.com/intern/diff/D56315533/) Pull Request resolved: #124422 Approved by: https://github.com/yf225 ghstack dependencies: #124421
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
May 3, 2024
…rch#123424) In order to make replicate work with Meta tensor, we need to do lazy Initialization for the replicate API. This PR impelements the lazy initialization and ensures that replicate still work with the new DDP compilation. Differential Revision: [D55787340](https://our.internmc.facebook.com/intern/diff/D55787340/) Pull Request resolved: pytorch#123424 Approved by: https://github.com/yf225 ghstack dependencies: pytorch#124421, pytorch#124422
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
As title Differential Revision: [D56508696](https://our.internmc.facebook.com/intern/diff/D56508696/) Pull Request resolved: #124829 Approved by: https://github.com/yf225 ghstack dependencies: #124421, #124422, #123424
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
As title Differential Revision: [D56521582](https://our.internmc.facebook.com/intern/diff/D56521582/) Pull Request resolved: #124846 Approved by: https://github.com/LucasLLC, https://github.com/wz337 ghstack dependencies: #124421, #124422, #123424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D56315534
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k