Fix layer norm in static runtime when input is non-contiguous #124789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124789
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 45af315 with merge base c82fcb7 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
davidberard98
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
sweet, thanks (to you and @swolchok)!
note: I was wondering whether it's worth putting this behind a JK. I feel like probably not:
- we can't train with static runtime, so there shouldn't be any models trained with this bad behavior
- it seems basically impossible that you'd have a model that's (a) trained on the correct behavior (b) now serving with incorrect static runtime behavior, and (c) would start behaving more badly once we fix the static runtime behavior.
@houseroad Do you think this is a risky change to the existing models? |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
alat-rights
pushed a commit
to alat-rights/pytorch
that referenced
this pull request
Apr 26, 2024
…h#124789) Test: The added unit test fails before this fix. But it passes now after the fix. The fix is coming from @swolchok in D56087067. Pull Request resolved: pytorch#124789 Approved by: https://github.com/davidberard98
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
May 3, 2024
…h#124789) Test: The added unit test fails before this fix. But it passes now after the fix. The fix is coming from @swolchok in D56087067. Pull Request resolved: pytorch#124789 Approved by: https://github.com/davidberard98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Test: The added unit test fails before this fix. But it passes now after the fix.
The fix is coming from @swolchok in D56087067.