Expose tensor check from guard for reusing #124836
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124836
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ba31f7e with merge base 61e937f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
EikanWang
requested review from
Chillee,
anijain2305,
desertfire,
jansel and
jgong5
cc voznesenskym penguinwu jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
| void* convert_to_root_guard_manager(py::object root); | ||
| bool run_root_guard_manager(void* root, PyObject* f_locals); | ||
|
|
||
| struct LocalState { |
There was a problem hiding this comment.
Should we add namespace to avoid naming collision?
There was a problem hiding this comment.
Yes, we should, and the namespace should be namespace torch::dynamo. I'm just not sure about the namespace scope. Should we add convert_to_root_guard_manager and run_root_guard_manager to the namespace as well? @anijain2305
There was a problem hiding this comment.
Let's move everything to torch::dynamo scope
There was a problem hiding this comment.
Thanks, I will refine it.
cc voznesenskym penguinwu jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
cc voznesenskym penguinwu jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
cc voznesenskym penguinwu jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
cc voznesenskym penguinwu jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: New commits were pushed while merging. Please rerun the merge command. Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Pull Request resolved: pytorch#124836 Approved by: https://github.com/jgong5, https://github.com/jansel, https://github.com/desertfire
ghstack-source-id: 54e22b1 Pull Request resolved: pytorch/pytorch#124836
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang