Skip to content

add methods for open device in PackedSequence module. #124923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add methods for open device in PackedSequence module. #124923

wants to merge 1 commit into from

Conversation

Shan19900305
Copy link
Contributor

  1. add is_{custom_device_name}() and {custom_device_name}() for open device register;
  2. fix open device failed testcases.

@ezyang @bdhirsh

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124923

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0de2fa9 with merge base b04dca1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang
ezyang reviewed Apr 25, 2024
View reviewed changes
test/cpp_extensions/open_registration_extension.cpp
m.impl("_foreach_add.List", torch::CppFunction::makeFromBoxedFunction<&custom_cpu_fallback>());
m.impl("index.Tensor", torch::CppFunction::makeFromBoxedFunction<&custom_cpu_fallback>());
m.impl("triu.indices", torch::CppFunction::makeFromBoxedFunction<&custom_cpu_fallback>());
m.impl("triu_indices", torch::CppFunction::makeFromBoxedFunction<&custom_cpu_fallback>());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

@Shan19900305
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 26, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@Shan19900305
Copy link
Contributor Author

@ezyang Hi, yang. Pls add a label for this pr.

@ezyang ezyang added the topic: not user facing topic category label Apr 26, 2024
@ezyang
Copy link
Contributor

ezyang commented Apr 26, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Shan19900305 Shan19900305 deleted the main_add_private_user_support_in_rnn_module branch April 27, 2024 01:24
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
@Shan19900305
add methods for open device in PackedSequence module. (#124923)
7de1bb2 
1) add is_{custom_device_name}() and {custom_device_name}() for open device register;
2) fix open device failed testcases.

@ezyang  @bdhirsh
Pull Request resolved: #124923
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Shan19900305 @pytorchmergebot @ezyang @pytorchbot