-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Adding Compare in torch.utils.benchmark documentation #125009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125009
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 864eae5 with merge base da991fa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
d0b37ab
to
e3b1e35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
edit: Actually it looks like there are no docstrings for this class. Would you be willing to add them?
Added a docstring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a docstring for all the non private methods of compare please
You might need to run lintrunner to fix lint |
Sorry for that, my pre-commit was not activated... |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
torch.utils.benchmark.Compare
is not directly exposed in torch.utils.benchmark documentation.I think this is a valuable resource to add since it can help people embracing the torch benchmark way of doing things, and help people building documentation towards it.