Skip to content

Conversation

Ghelfi
Copy link
Contributor

@Ghelfi Ghelfi commented Apr 26, 2024

torch.utils.benchmark.Compare is not directly exposed in torch.utils.benchmark documentation.

I think this is a valuable resource to add since it can help people embracing the torch benchmark way of doing things, and help people building documentation towards it.

Copy link

pytorch-bot bot commented Apr 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125009

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 864eae5 with merge base da991fa (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

linux-foundation-easycla bot commented Apr 26, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@Ghelfi Ghelfi force-pushed the add-compare-to-doc branch from d0b37ab to e3b1e35 Compare April 26, 2024 10:16
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

edit: Actually it looks like there are no docstrings for this class. Would you be willing to add them?

@Ghelfi
Copy link
Contributor Author

Ghelfi commented Apr 27, 2024

Added a docstring.

@Ghelfi Ghelfi requested a review from mikaylagawarecki April 27, 2024 11:28
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a docstring for all the non private methods of compare please

@Ghelfi Ghelfi requested a review from mikaylagawarecki May 2, 2024 15:49
@mikaylagawarecki
Copy link
Contributor

You might need to run lintrunner to fix lint

@Ghelfi
Copy link
Contributor Author

Ghelfi commented May 2, 2024

Sorry for that, my pre-commit was not activated...

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 2, 2024
@mikaylagawarecki mikaylagawarecki added release notes: python_frontend python frontend release notes category topic: docs topic category and removed ciflow/trunk Trigger trunk jobs on your pull request labels May 2, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged open source release notes: python_frontend python frontend release notes category topic: docs topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants