Skip to content

Don't run auto grad safe mode when predispatch is on #125066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Don't run auto grad safe mode when predispatch is on #125066

wants to merge 1 commit into from

Conversation

tugsbayasgalan
Copy link
Contributor

Summary: Title

Test Plan: CI

Differential Revision: D56646678

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125066

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3e79ae4 with merge base 6761b49 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 26, 2024
@tugsbayasgalan tugsbayasgalan force-pushed the export-D56646678 branch 2 times, most recently from 7a17b20 to b80fee5 Compare April 28, 2024 16:30
@tugsbayasgalan @facebook-github-bot
Don't run auto grad safe mode when predispatch is on
3e79ae4 
Summary: Title

Test Plan: CI

Reviewed By: zhxchen17

Differential Revision: D56646678
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
@tugsbayasgalan
Don't run auto grad safe mode when predispatch is on (pytorch#125066)
2944c84 
Summary: Title

Test Plan: CI

Differential Revision: D56646678

Pull Request resolved: pytorch#125066
Approved by: https://github.com/zhxchen17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhxchen17 zhxchen17 zhxchen17 approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tugsbayasgalan @facebook-github-bot @pytorchmergebot @zhxchen17