Skip to content

Conversation

bddppq
Copy link
Contributor

@bddppq bddppq commented Oct 11, 2018

No description provided.

@bddppq bddppq requested review from ezyang and yf225 October 11, 2018 21:21
@bddppq
Copy link
Contributor Author

bddppq commented Oct 11, 2018

Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can update the Docker image version tag as part of this PR after the docker trigger finishes. And after updating the Docker version tag here we should update it in DockerVersion.groovy as well.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bddppq is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants