Skip to content

[TD] Enable test removal on most default configs + distributed CUDA for everyone #125931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[TD] Enable test removal on most default configs + distributed CUDA for everyone #125931

wants to merge 7 commits into from

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented May 10, 2024 •
edited
Loading

yolo

Add the longest jobs in pull:

  • default cpu configs
  • non sm86 cuda
  • distributed cuda for everyone

Still excluding

  • slow, inductor, rocm, onnx, mac, dynamo
  • distributed cpu
  • windows cuda

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125931

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b9a423e with merge base 3267814 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@clee2000 clee2000 marked this pull request as ready for review May 10, 2024 20:48
@clee2000 clee2000 requested a review from a team as a code owner May 10, 2024 20:48
@clee2000 clee2000 changed the title [TD] Enable test removal on almost everything [TD] Enable test removal on most default configs + distributed CUDA for everyone May 10, 2024
@clee2000 clee2000 added the ciflow/trunk Trigger trunk jobs on your pull request label May 10, 2024
huydhn
huydhn reviewed May 13, 2024
View reviewed changes
test/run_test.py
or TEST_CONFIG == "nogpu_AVX512"
or TEST_CONFIG == "nogpu_NO_AVX2"
or (
"sm86" not in BUILD_ENVIRONMENT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the logic to check for "sm86" here looks a bit awkward I think because that can be changed in the future. But this is probably ok because I assume this is only temporary

Copy link
Contributor Author

@clee2000 clee2000 May 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah all of the logic here is a bit cursed because of how specific the inclusions and exclusions are

@clee2000
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the csl/td_cuda_dist branch June 14, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@ZainRizvi ZainRizvi ZainRizvi approved these changes

Assignees

No one assigned

Labels

ci-td-distributed ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clee2000 @pytorchmergebot @huydhn @ZainRizvi