Skip to content

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented May 16, 2024

Stack from ghstack (oldest at bottom):

The following are all constrained under the ONNX exporter project scope.

  • personal_of_interest.rst
  • CODEOWNERS
    • Removing folks no longer working on the project.
    • Updating new owners who will now be notified with PRs related to
      the specific file paths.
  • merge_rules.yaml
    • Removing folks no longer working on the project.

🫡

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126364

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 325b98f with merge base 6079c50 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

BowenBao added a commit that referenced this pull request May 16, 2024
….yaml'

The following are all constrained under the ONNX exporter project scope.

- `personal_of_interest.rst`
  - Moving folks no longer working on the project to emeritus.
  - Adding justinchuby, titaiwangms, shubhambhokare1 and xadupre,
    who have all made countless contributions to this project.
- `CODEOWNERS`
  - Removing folks no longer working on the project.
  - Updating new owners who will now be notified with PRs related to
    the specific file paths.
- `merge_rules.yaml`
  - Removing folks no longer working on the project.

ghstack-source-id: c21e8d7
Pull Request resolved: #126364
@BowenBao BowenBao added the topic: not user facing topic category label May 16, 2024
@BowenBao BowenBao marked this pull request as ready for review May 16, 2024 17:56
@BowenBao BowenBao requested review from a team, thiagocrepaldi and wschin as code owners May 16, 2024 17:56
@titaiwangms
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 17, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@titaiwangms
Copy link
Collaborator

@malfet PTAL

@titaiwangms
Copy link
Collaborator

@kit1980 PTAL

@titaiwangms titaiwangms added the onnx-needs-import This PR is related to ONNX, but touches files outside of merge rule patterns, and hence needs import label May 23, 2024
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@justinchuby
Copy link
Collaborator

@pytorchbot merge --rebase

@justinchuby justinchuby removed the onnx-needs-import This PR is related to ONNX, but touches files outside of merge rule patterns, and hence needs import label Jun 15, 2024
@justinchuby justinchuby added module: onnx Related to torch.onnx and removed module: dynamo labels Jun 15, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/BowenBao/315/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/126364)

pytorchmergebot pushed a commit that referenced this pull request Jun 15, 2024
….yaml'

The following are all constrained under the ONNX exporter project scope.

- `personal_of_interest.rst`
  - Moving folks no longer working on the project to emeritus.
  - Adding justinchuby, titaiwangms, shubhambhokare1 and xadupre,
    who have all made countless contributions to this project.
- `CODEOWNERS`
  - Removing folks no longer working on the project.
  - Updating new owners who will now be notified with PRs related to
    the specific file paths.
- `merge_rules.yaml`
  - Removing folks no longer working on the project.

ghstack-source-id: 8c7931c
Pull Request resolved: #126364
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/BowenBao/315/head branch July 17, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: onnx Related to torch.onnx open source release notes: releng release notes category topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants