Skip to content

Conversation

@dshi7
Copy link
Contributor

@dshi7 dshi7 commented May 16, 2024

Internal D57459752 returns manifold URL and this PR adds to tlparse payload

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang

@pytorch-bot
Copy link

pytorch-bot bot commented May 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126451

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit b3b9139 with merge base 5fb11cd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@dshi7
Copy link
Contributor Author

dshi7 commented May 16, 2024

@pytorchbot label "release notes: profiler"

@pytorch-bot pytorch-bot bot added the release notes: profiler release notes category label May 16, 2024
torch._logging.trace_structured(
"link",
lambda: {
"name": "manifold_url",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's actually call this something like "cprofile_url" or "cprofile_manifold_url", since that's how it will show up on tlparse:
image
(Will sort the build products too at some point)

@dshi7
Copy link
Contributor Author

dshi7 commented May 17, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased trace_structured onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout trace_structured && git pull --rebase)

@dshi7
Copy link
Contributor Author

dshi7 commented May 20, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased trace_structured onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout trace_structured && git pull --rebase)

@dshi7
Copy link
Contributor Author

dshi7 commented May 20, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 20, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@dshi7
Copy link
Contributor Author

dshi7 commented May 21, 2024

@pytorchbot merge

@facebook-github-bot
Copy link
Contributor

@dshi7 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: profiler release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants